-
Notifications
You must be signed in to change notification settings - Fork 411
Cut 0.1.1 #3568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cut 0.1.1 #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab4e8c1
to
e4fffb2
Compare
tnull
reviewed
Jan 28, 2025
e4fffb2
to
cd0e008
Compare
valentinewallace
approved these changes
Jan 28, 2025
wpaulino
approved these changes
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.1 #3568 +/- ##
==========================================
+ Coverage 88.39% 88.40% +0.01%
==========================================
Files 149 149
Lines 113678 113684 +6
Branches 113678 113684 +6
==========================================
+ Hits 100487 100504 +17
+ Misses 10734 10722 -12
- Partials 2457 2458 +1 ☔ View full report in Codecov by Sentry. |
jkczyz
reviewed
Jan 28, 2025
cd0e008
to
97c2dcd
Compare
Grr, fixed the typo: $ git diff-tree -U2 cd0e008ed 97c2dcd33
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e9acf4f05..be12be58d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,6 @@
* Fixed the additional feerate we will pay each time we RBF on-chain claims to
match the Bitcoin Core policy (1 sat/vB) instead of 16 sats/vB (#3457).
- * Fixed a cased where a custom `Router` which returns an invalid `Router`,
- provided to `ChannelManager` can result in an outbound payment remaining
+ * Fixed a cased where a custom `Router` which returns an invalid `Route`,
+ provided to `ChannelManager`, can result in an outbound payment remaining
pending forever despite no HTLCs being pending (#3531). |
jkczyz
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.