forbid unsafe #357
Closed
forbid unsafe #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasblummer
force-pushed
the
forbid_unsafe
branch
from
40b7d7e to
e277eda
Compare
tamasblummer
force-pushed
the
forbid_unsafe
branch
from
e277eda to
1aa64c5
Compare
TheBlueMatt
reviewed
Jul 24, 2019
| let mut res: Vec<msgs::OnionHopData> = Vec::with_capacity(route.hops.len()); | ||
| internal_traits::test_no_dealloc::<msgs::OnionHopData>(None); | ||
| unsafe { res.set_len(route.hops.len()); } | ||
| let mut res: Vec<msgs::OnionHopData> = vec![msgs::OnionHopData::default(); route.hops.len()]; |
There was a problem hiding this comment.
Would prefer to just insert(0, ...) at each loop iteration to make things even cleaner.
There was a problem hiding this comment.
do not know how to insert if not initialized. vec capacity != len
There was a problem hiding this comment.
if vec length is not 20*65 shift will fail
There was a problem hiding this comment.
Oops, I missed this, point was we don't shift on this vec, only on a later version of it, this one is always route.hops.len() in len at the end.
Merged
|
Taken as #358. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this. I do not think performance hit justifies unsafe language use.