Skip to content

Drop some useless TODO messages to clean things up pre-0.1 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Drop some useless TODO messages to clean things up pre-0.1 #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95dc276
Drop update_fee TODOs as we're gonna drop it before 0.1 anyway
TheBlueMatt Jul 28, 2019
ce6f561
Drop TODO suggesting we avoid a test-only function to get chan keys
TheBlueMatt Jul 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/ln/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,6 @@ impl Channel {
{
// Make sure that the to_self/to_remote is always either past the appropriate
// channel_reserve *or* it is making progress towards it.
// TODO: This should happen after fee calculation, but we don't handle that correctly
// yet!
let mut max_commitment_tx_output = if generated_by_local {
self.max_commitment_tx_output_local.lock().unwrap()
} else {
Expand Down Expand Up @@ -2452,7 +2450,7 @@ impl Channel {
update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
msgs::CommitmentUpdate {
update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
update_fee: None, //TODO: We need to support re-generating any update_fees in the last commitment_signed!
update_fee: None,
commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
}
}
Expand Down Expand Up @@ -2833,7 +2831,6 @@ impl Channel {
self.cur_remote_commitment_transaction_number + 2
}

//TODO: Testing purpose only, should be changed in another way after #81
#[cfg(test)]
pub fn get_local_keys(&self) -> &ChannelKeys {
&self.local_keys
Expand Down