Skip to content

Make SocketDescriptor::send_data take slice instead of vec and offset #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rrybarczyk
Copy link
Contributor

@rrybarczyk rrybarczyk commented Jul 31, 2019

By taking in a slice, we can avoid forcing the caller to pass in write_offset.

Another added benefit is that you can pass in slices or anything that can be converted to a slice, including a vec.

Also, added the net-tokio target directory to the .gitignore. Can put this a different PR if preferred.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #369 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   87.33%   87.34%   +0.01%     
==========================================
  Files          29       29              
  Lines       15605    15605              
==========================================
+ Hits        13628    13630       +2     
+ Misses       1977     1975       -2
Impacted Files Coverage Δ
src/ln/peer_handler.rs 31.81% <0%> (ø) ⬆️
src/ln/functional_tests.rs 96.38% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d16296...4d3f88e. Read the comment docs.

@TheBlueMatt
Copy link
Collaborator

Awesome, looks great! You can tell what bits I wrote before I knew rust very well...Will take as #370 (which just fixed a few indentation things that slipped in here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants