Fix possible dust HTLC sweep tx when feerate remains unchanged during a bump #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3832 +/- ##
==========================================
- Coverage 89.91% 89.90% -0.01%
==========================================
Files 160 160
Lines 129307 129581 +274
Branches 129307 129581 +274
==========================================
+ Hits 116270 116505 +235
- Misses 10349 10383 +34
- Partials 2688 2693 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wpaulino
reviewed
Jun 6, 2025
There was a problem hiding this comment.
Thanks! Do you mind updating the commit message to follow these guidelines?
When bumping an HTLC sweep transaction, if the feerate remains unchanged, `feerate_bump` doesn't check whether the output amount is below the dust limit. However, this situation can occur if the transaction's inputs are modified. See also: lightningdevkit#3831
whfuyn
force-pushed
the
fix-dust-htlc-sweep-tx
branch
from
1a19a4a to
ab132ab
Compare
|
Hi, @wpaulino. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3831