Construct funding redeem script in signer #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devrandom
commented
Jan 10, 2020
devrandom
force-pushed
the
funding-script
branch
from
1674900 to
08a9495
Compare
ariard
approved these changes
Jan 10, 2020
|
(please wait for rebase on other PR before merging this) |
devrandom
force-pushed
the
funding-script
branch
2 times, most recently
from
8a93f13 to
028f250
Compare
|
rebased and squashed |
TheBlueMatt
reviewed
Jan 16, 2020
TheBlueMatt
approved these changes
Jan 16, 2020
devrandom
force-pushed
the
funding-script
branch
from
259f6c6 to
6200302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set remote funding key on channel accept and use that to create the funding redeem script in the signer instead of passing it in.
This depends on #442, so please review just the last commit.