Increase visibility for external integration tests #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Jan 16, 2020
devrandom
force-pushed
the
visibility-for-test
branch
from
3c885ef to
4b41600
Compare
TheBlueMatt
approved these changes
Jan 16, 2020
devrandom
force-pushed
the
visibility-for-test
branch
from
4b41600 to
481e221
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am starting an external integration test suite using rust-lightning. I found that I needed the following visibility increases in order to be able to compile a functional test. For example, visibility of
InitFeaturesis needed to orchestrate channel opening viahandle_open_channel.Is there an alternative way of achieving this?
The tests are here: https://gitlab.com/lightning-signer/rust-lightning-signer - mostly cribbed from one of the internal rust-lightning functional tests.