Panic on txn with value > 21mill in ChannelMonitor::block_connected, Clean up fuzz targets a bit

fuzz/src/bin/chanmon_consistency_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::chanmon_consistency::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	chanmon_consistency_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	chanmon_consistency_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/chanmon_consistency") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			chanmon_consistency_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/chanmon_deser_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::chanmon_deser::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	chanmon_deser_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	chanmon_deser_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/chanmon_deser") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			chanmon_deser_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/full_stack_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::full_stack::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	full_stack_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	full_stack_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/full_stack") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			full_stack_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_accept_channel_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_accept_channel::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_accept_channel_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_accept_channel_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_accept_channel") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_accept_channel_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_announcement_signatures_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_announcement_signatures::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_announcement_signatures_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_announcement_signatures_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_announcement_signatures") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_announcement_signatures_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_channel_announcement_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_channel_announcement::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_channel_announcement_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_channel_announcement_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_channel_announcement") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_channel_announcement_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_channel_reestablish_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_channel_reestablish::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_channel_reestablish_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_channel_reestablish_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_channel_reestablish") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_channel_reestablish_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_channel_update_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_channel_update::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_channel_update_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_channel_update_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_channel_update") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_channel_update_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_closing_signed_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_closing_signed::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_closing_signed_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_closing_signed_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_closing_signed") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_closing_signed_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_commitment_signed_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_commitment_signed::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_commitment_signed_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_commitment_signed_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_commitment_signed") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_commitment_signed_run(data.as_ptr(), data.len());
+		}
+	}
+}

fuzz/src/bin/msg_decoded_onion_error_packet_target.rs

@@ -1,12 +1,12 @@
 // This file is auto-generated by gen_target.sh based on target_template.txt
 // To modify it, modify target_template.txt and run gen_target.sh instead.
 
-//Uncomment this for libfuzzer builds:
-//#![no_main]
+#![cfg_attr(feature = "libfuzzer_fuzz", no_main)]
 
 extern crate lightning_fuzz;
 use lightning_fuzz::msg_targets::msg_decoded_onion_error_packet::*;
 
+use std::fs;
 use std::io::Read;
 
 #[cfg(feature = "afl")]
@@ -42,3 +42,18 @@ fn main() {
 	std::io::stdin().read_to_end(&mut data).unwrap();
 	msg_decoded_onion_error_packet_run(data.as_ptr(), data.len());
 }
+
+#[test]
+fn run_test_cases() {
+	let mut data: Vec<u8> = vec![0];
+	msg_decoded_onion_error_packet_run(data.as_ptr(), data.len());
+	if let Ok(tests) = fs::read_dir("test_cases/msg_decoded_onion_error_packet") {
+		for test in tests {
+			data.clear();
+			let path = test.unwrap().path();
+			println!("Running test {}...", path.file_name().unwrap().to_str().unwrap());
+			fs::File::open(path).unwrap().read_to_end(&mut data).unwrap();
+			msg_decoded_onion_error_packet_run(data.as_ptr(), data.len());
+		}
+	}
+}