Skip to content

Channel value to ChannelKeys constructor #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2020

Conversation

devrandom
Copy link
Member

@devrandom devrandom commented Jan 23, 2020

Channel value is a constant, so does not need to be supplied on each signing operation.

Also, remove unneeded funding redeem script argument to sign_closing_transaction.

@devrandom
Copy link
Member Author

Perhaps ChannelKeys should be renamed to ChannelSigner.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yea, ChannelKeys could use a rename, but doesn't have to happen here. Plus its not like it doesnt still expose all the kyes for ChannelMonitor :(

@TheBlueMatt TheBlueMatt merged commit af4738b into lightningdevkit:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants