-
Notifications
You must be signed in to change notification settings - Fork 412
First draft, don't-cover-everything-but-yet-a-good-start-CONTRIBUTING.md #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheBlueMatt
merged 1 commit into
lightningdevkit:master
from
ariard:2020-01-contributing-draft
Feb 12, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
Contributing to Rust-Lightning | ||
============================== | ||
|
||
The Rust-Lightning project operates an open contributor model where anyone is | ||
welcome to contribute towards development in the form of peer review, documentation, | ||
testing and patches. | ||
|
||
Anyone is invited to contribute without regard to technical experience, "expertise", OSS | ||
experience, age, or other concern. Though developing cryptocurrencies demand a | ||
high-level of rigor, adversial thinking, thorough testing and risk-minimization. | ||
Any bug may cost users real money. That said we're deeply welcoming people contributing | ||
for the first time to an open source project or pick up Rust while contributing. Don't be shy, | ||
you'll learn. | ||
|
||
Communications Channels | ||
----------------------- | ||
|
||
Communication about Rust-Lightning happens primarily on #ldk-dev on the LDK slack | ||
or #rust-bitcoin on IRC Freenode. | ||
|
||
Discussion about code base improvements happens in GitHub issues and on pull | ||
requests. | ||
|
||
Contribution Workflow | ||
-------------------- | ||
|
||
The codebase is maintained using the "contributor workflow" where everyone | ||
without exception contributes patch proposals using "pull requests". This | ||
facilitates social contribution, easy testing and peer review. | ||
|
||
To contribute a patch, the worflow is a as follows: | ||
|
||
1. Fork Repository | ||
2. Create topic branch | ||
3. Commit patches | ||
|
||
|
||
In general commits should be atomic and diffs should be easy to read. | ||
For this reason do not mix any formatting fixes or code moves with | ||
actual code changes. Further, each commit, individually, should compile | ||
and pass tests, in order to ensure git bisect and other automated tools | ||
function properly. | ||
|
||
When adding a new feature, like implementing a BOLT spec object, thought | ||
must be given to the long term technical debt. Every new features should | ||
be covered by functional tests. | ||
|
||
When refactoring, structure your PR to make it easy to review and don't | ||
hesitant to split in multiple small, focused PRs. | ||
|
||
The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis). | ||
|
||
Commit should expose both issues fixed and solutions rational. | ||
these [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. | ||
|
||
Peer review | ||
----------- | ||
|
||
Anyone may participate in peer review which is expressed by comments in the pull | ||
request. Typically reviewers will review the code for obvious errors, as well as | ||
test out the patch set and opine on the technical merits of the patch. PR should | ||
be reviewed first on the conceptual level before focusing on code style or grammar | ||
fixes. | ||
|
||
Coding Conventions | ||
------------ | ||
|
||
Use tabs. If you want to align lines, use spaces. Any desired alignment should | ||
display fine at any tab-length display setting. | ||
|
||
Security | ||
-------- | ||
|
||
Security is the primary focus of Rust-Lightning, disclosure of security vulnerabilites | ||
helps prevent user loss of funds. If you believe vulnerability may effect other Lightning | ||
implementations please inform them. | ||
|
||
Note that Rust-Lightning is currently considered "pre-production" during this time, there | ||
is no special handling of security issues. Please simpy open an issue on Github. | ||
|
||
Testing | ||
------- | ||
|
||
Deeply tied with the security aspect, Rust-Lightning developers take testing | ||
very seriously. Due to the modular nature of the project writing new functional | ||
tests is easy and good test coverage of the codebase is an important goal. Refactoring | ||
the project to enable fine-grained unit testing is also an ongoing work. | ||
|
||
Fuzzing is heavily-encouraged, you will find all related fuzzing stuff under `fuzz/` | ||
|
||
Mutation testing is work-in-progess, any contribution there would be warmly welcomed. | ||
|
||
Going further | ||
------------- | ||
|
||
You may be interested by Jon Atack guide on [How to review Bitcoin Core PRs](https://github.com/jonatack/bitcoin-development/blob/master/how-to-review-bitcoin-core-prs.md) | ||
and [How to make Bitcoin Core PRs](https://github.com/jonatack/bitcoin-development/blob/master/how-to-make-bitcoin-core-prs.md). | ||
Modulo projects context and diffference of maturity there is a lot to stick to. | ||
|
||
Overall, have fun :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth stating the criteria used for merging? Or leave to a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, @TheBlueMatt should we enforce the at-least 2-ACK for any substantial changes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was kinda figuring leave it as a followup - we just dumped 4 new full-time contributors on the project, so I was kinda waiting until folks were up to speed and felt more comfortable with the codebase then we'd revisit it and do something like 2 acks from regular contributors or so (like rust-bitcoin).