Test that do_attempt_write_data does not infinitely loop #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
force-pushed
the
add-PR550-test
branch
from
5b3347c to
780a3f7
Compare
|
I think infinitely looping in a test is a perfectly reasonable failure mode, especially given the code in question infinite looped in production :) |
TheBlueMatt
reviewed
Mar 21, 2020
valentinewallace
force-pushed
the
add-PR550-test
branch
from
780a3f7 to
bb210c0
Compare
valentinewallace
force-pushed
the
add-PR550-test
branch
from
bb210c0 to
2b43d31
Compare
valentinewallace
force-pushed
the
add-PR550-test
branch
5 times, most recently
from
6d88fe7 to
1d77598
Compare
|
Travis got screwed up. Can you git commit --amend (just to change the timestamp and commitid) and then push so that travis runs? |
valentinewallace
force-pushed
the
add-PR550-test
branch
from
1d77598 to
b7925d9
Compare
TheBlueMatt
reviewed
Mar 27, 2020
valentinewallace
force-pushed
the
add-PR550-test
branch
3 times, most recently
from
b5503f9 to
24aa9fc
Compare
TheBlueMatt
approved these changes
Mar 27, 2020
when all the channel messages can't fit into the buffer. Adds a test for PR lightningdevkit#550.
valentinewallace
force-pushed
the
add-PR550-test
branch
from
24aa9fc to
3e0aed2
Compare
|
Travis is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when all the channel messages can't fit into the buffer.
Adds a test for PR #550.
This test may still need work because it doesn't fail with the previous code per se, just infinitely loops. But, it technically would've caught the problem.