-
Notifications
You must be signed in to change notification settings - Fork 411
Add content to readme #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Change header to "Rust-Lightning" - Add crate and documentation badges - Add introductory paragraph - Move previous intro content under "Status" heading
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 92.00% 92.01% +0.01%
==========================================
Files 37 37
Lines 20106 20106
==========================================
+ Hits 18498 18501 +3
+ Misses 1608 1605 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good sans one note.
README.md
Outdated
it is runtime-agnostic, but users must implement basic networking logic, chain | ||
interactions, and disk storage. | ||
|
||
The `lightning-net-tokio` crate is a full Lightning using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently only implement the network-connection stuff. #681 does disk I/O (in a separate crate), and hopefully future ones will do chain sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
I wasn't sure where to put the old joke, but please feel free to push it to this PR branch.
Closes #728