Skip to content

Unknown bits feature only needs to be validated once #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

galderz
Copy link
Contributor

@galderz galderz commented Feb 5, 2021

Closes #792.

Removed the redundant validation logic.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #793 (cae0ce8) into main (e4b516d) will decrease coverage by 0.09%.
The diff coverage is 88.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   90.80%   90.71%   -0.10%     
==========================================
  Files          38       44       +6     
  Lines       23168    24052     +884     
==========================================
+ Hits        21038    21818     +780     
- Misses       2130     2234     +104     
Impacted Files Coverage Δ
lightning-block-sync/src/lib.rs 0.00% <0.00%> (ø)
lightning/src/ln/peer_handler.rs 49.79% <0.00%> (+0.06%) ⬆️
lightning-block-sync/src/rest.rs 65.45% <65.45%> (ø)
lightning/src/ln/msgs.rs 89.46% <75.00%> (ø)
lightning-block-sync/src/rpc.rs 78.37% <78.37%> (ø)
lightning-block-sync/src/convert.rs 92.80% <92.80%> (ø)
lightning-block-sync/src/http.rs 95.03% <95.03%> (ø)
lightning-block-sync/src/utils.rs 100.00% <100.00%> (ø)
lightning/src/routing/network_graph.rs 90.89% <100.00%> (-0.09%) ⬇️
lightning/src/ln/functional_tests.rs 96.98% <0.00%> (-0.06%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b516d...048e862. Read the comment docs.

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK 048e862

Thanks for cleaning up this!

@TheBlueMatt TheBlueMatt merged commit 6dcb7c4 into lightningdevkit:main Feb 5, 2021
@galderz galderz deleted the t_double_validation_792 branch February 5, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary double validation of unknown bits feature
3 participants