Benchmark get_route in CI #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-02-route-bench
branch
from
d9298af to
94334df
Compare
Codecov Report
@@ Coverage Diff @@
## main #798 +/- ##
==========================================
- Coverage 90.84% 90.82% -0.02%
==========================================
Files 44 44
Lines 24073 24073
==========================================
- Hits 21868 21865 -3
- Misses 2205 2208 +3
Continue to review full report at Codecov.
|
Merged
TheBlueMatt
force-pushed
the
2021-02-route-bench
branch
from
94334df to
29d0644
Compare
TheBlueMatt
force-pushed
the
2021-02-route-bench
branch
from
29d0644 to
ab92277
Compare
|
Note for reviewers, the graph snapshot has 33,895 channels in it, which is lower than the 37,851 that 1ml lists today, but not by enough for it to matter too much. |
TheBlueMatt
force-pushed
the
2021-02-route-bench
branch
2 times, most recently
from
9cfaae9 to
6ebab85
Compare
Sadly rust upstream never really figured out the benchmark story, and it looks like the API we use here may not be long for this world. Luckily, we can switch to criterion with largely the same API if that happens before upstream finishes ongoing work with the custom test framework stuff. Sadly, it requires fetching the current network graph, which I did using Val's route-testing script written to test the MPP router.
TheBlueMatt
force-pushed
the
2021-02-route-bench
branch
from
6ebab85 to
454e01d
Compare
|
Code Review ACK 454e01d |
|
This doesn't touch "real" code, so gonna merge with one ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to create this for another thing anyway, so figured I'd PR. It uses rust unstable features, but its mostly for CI.