Drop C bindings (which are now in a separate repo) #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should remove one big red X in our builds, making it harder to miss other failing tests.
This allows us to drop the usually-failing C bindings CI check, and makes Github code search more useful by dropping redundant things.
|
C bindings are now at https://github.com/lightningdevkit/ldk-c-bindings though I need to update them to work out-of-repo. |
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
=======================================
Coverage 90.97% 90.98%
=======================================
Files 48 48
Lines 26538 26538
=======================================
+ Hits 24144 24145 +1
+ Misses 2394 2393 -1
Continue to review full report at Codecov.
|
jkczyz
approved these changes
Mar 8, 2021
|
only + in the diff is codecov settings, gonna merge under "bindings updates only take one ack" rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to drop the usually-failing C bindings CI check, and
makes Github code search more useful by dropping redundant things.