Skip to content

Mention storage req for users with a public invoice generation API #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #905 (f02910f) into main (cb0b4bf) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   90.39%   90.50%   +0.11%     
==========================================
  Files          57       57              
  Lines       29500    30225     +725     
==========================================
+ Hits        26666    27356     +690     
- Misses       2834     2869      +35     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 85.92% <ø> (+2.50%) ⬆️
lightning/src/ln/functional_tests.rs 96.98% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0b4bf...f02910f. Read the comment docs.

Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7be555a

@TheBlueMatt TheBlueMatt force-pushed the 2021-04-mention-invoice-storage-docs branch from 7be555a to f02910f Compare April 29, 2021 22:02
@TheBlueMatt
Copy link
Collaborator Author

Trivial grammar fix, will take after CI passes:

$ git diff-tree -U1 7be555a3a f02910f81
diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index 0b601c5ce..58b6982c4 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -3471,3 +3471,3 @@ impl<Signer: Sign, M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelMana
 	/// Pending inbound payments are stored in memory and in serialized versions of this
-	/// [`ChannelManager`], if potentially unbounded numbers of inbound payments may exist and
+	/// [`ChannelManager`]. If potentially unbounded numbers of inbound payments may exist and
 	/// space is limited, you may wish to rate-limit inbound payment creation.
$

@TheBlueMatt TheBlueMatt merged commit 3be185a into lightningdevkit:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants