Skip to content

Always log_info when we broadcast a transaction, including the txid #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #914 (1c948ec) into main (c9b12e1) will increase coverage by 0.05%.
The diff coverage is 92.85%.

❗ Current head 1c948ec differs from pull request most recent head 71d640a. Consider uploading reports for the commit 71d640a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   90.51%   90.57%   +0.05%     
==========================================
  Files          59       59              
  Lines       29746    29751       +5     
==========================================
+ Hits        26926    26946      +20     
+ Misses       2820     2805      -15     
Impacted Files Coverage Δ
lightning/src/util/macro_logger.rs 88.88% <85.71%> (+1.79%) ⬆️
lightning/src/chain/channelmonitor.rs 95.46% <100.00%> (+<0.01%) ⬆️
lightning/src/ln/channelmanager.rs 84.03% <100.00%> (+0.05%) ⬆️
lightning/src/ln/onchaintx.rs 87.47% <100.00%> (+0.20%) ⬆️
lightning/src/ln/functional_tests.rs 97.04% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b12e1...71d640a. Read the comment docs.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

@TheBlueMatt TheBlueMatt force-pushed the 2021-05-log-txids branch from 1c948ec to 71d640a Compare May 6, 2021 18:49
@TheBlueMatt
Copy link
Collaborator Author

Squashed, only change from the original PR is the minor typo:

-				log_info!(logger, "Broadcasting onchaing {}", log_tx!(bump_tx));
+				log_info!(logger, "Broadcasting onchain {}", log_tx!(bump_tx));

@TheBlueMatt TheBlueMatt merged commit 85f1a91 into lightningdevkit:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants