Cache socket address in HttpClient for reconnect

[jkczyz]

If the HttpClient attempts to reconnect to bitcoind that is no longer running, the client fails to get the address from the stream. Cache the address when connecting to prevent this.

Fixes #930

[codecov]

Codecov Report

Merging #931 (4a12d76) into main (8e7b590) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   90.46%   90.45%   -0.01%     
==========================================
  Files          60       60              
  Lines       30592    30591       -1     
==========================================
- Hits        27674    27672       -2     
- Misses       2918     2919       +1     

Impacted Files	Coverage Δ
lightning-block-sync/src/http.rs	93.70% <100.00%> (-0.02%)	⬇️
lightning/src/ln/functional_tests.rs	96.80% <0.00%> (-0.04%)	⬇️
lightning/src/ln/channelmanager.rs	83.19% <0.00%> (+0.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7b590...4a12d76. Read the comment docs.

[devrandom]

İ'm not sure this is a good idea, since it effectively caches DNS lookups indefinitely.

[jkczyz]

İ'm not sure this is a good idea, since it effectively caches DNS lookups indefinitely.

Technically, this isn't any different behavior from before when using TcpStream::peer_addr. We'd have to parameterize HttpClient (rather than connect) by ToSocketAddrs to avoid any caching.