Downgrade prost-build to support for lower msrv #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Such checks are best performed in backend than having client checking empty or null value. This is also in-line with more critical requirement for functioning of NotFound introduced by MonitorUpdatingPersister Design. Even though there are some popular KVStore's which do not throw such exception on keyNotFound such as AWS-DDB (arguably the most popular one), we can still figure out that key didn't exist if value was returned as null or by similar means in other stores.
G8XSU
commented
Sep 19, 2023
| /// The write will succeed if the current DB version against the `key` is the same as in the request. | ||
| /// When initiating a `PutObjectRequest`, the request should contain their client-side `version` | ||
| /// for that key-value. | ||
| /// Clients are expected to store a `version` against every `key`. |
There was a problem hiding this comment.
auto-gen changes due to prost-build downgrade.
tnull
reviewed
Sep 19, 2023
| @@ -16,7 +16,7 @@ prost = "0.11.6" | |||
| reqwest = { version = "0.11.13", features = ["rustls-tls"] } | |||
|
|
|||
| [build-dependencies] | |||
| prost-build = { version = "0.11.3" } | |||
There was a problem hiding this comment.
I don't think a downgrade of prost-build is necessary here, but to address #4 we should define an MSRV, document it in README, and pin the downstream dependency in CI to assert we can build against it.
If we go for 1.63.0, adding an MSRV CI job that runs this should do the trick:
cargo update -p petgraph --precise "0.6.3" --verbose
(See for example how LDK Node's CI does it based on an msrv flag: https://github.com/lightningdevkit/ldk-node/blob/db1b7dcc3415ac00455913b48d4b7b8ec6c2e617/.github/workflows/build.yml#L42-L45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11