Skip to content

Add Tutorial for LOJ-1266: Points in Rectangle (en) #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 30, 2023

Conversation

Rabby033
Copy link
Contributor

super easy explanation

super easy explanation
@Rabby033 Rabby033 changed the title tutorials of 1266 no problem Tutorial added for LOJ- 1266 (points in rectangle) Mar 27, 2023
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya, here's a first pass. The overall write-up looks good. I only have a few suggestions here and there.

@rebornplusplus rebornplusplus changed the title Tutorial added for LOJ- 1266 (points in rectangle) Add Tutorial for LOJ-1266: Points in Rectangle (en) May 13, 2023
Rabby033 and others added 7 commits May 25, 2023 20:14
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Image Added in same directory
@Rabby033
Copy link
Contributor Author

@rebornplusplus please checkout my response according to your feedback

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary file solve.txt in the 1266/ directory. Please remove that.

I have added a few more suggestions to improve the PR. There are some recurring issues:

  • Please don't use <br>.
  • Please use a single space after a punctuation like ,, ., : etc. And before, usually don't add any spaces.

Rabby033 and others added 8 commits May 30, 2023 12:08
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
@Rabby033
Copy link
Contributor Author

@rebornplusplus I am requesting you to check it again . Changes done based on your feedback .

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@rebornplusplus rebornplusplus merged commit 9055a99 into lightoj-dev:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tutorial for LOJ-1266: Points in Rectangle (en)
2 participants