-
Notifications
You must be signed in to change notification settings - Fork 156
Add Tutorial for LOJ-1266: Points in Rectangle (en) #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
super easy explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya, here's a first pass. The overall write-up looks good. I only have a few suggestions here and there.
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Image Added in same directory
@rebornplusplus please checkout my response according to your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an unnecessary file solve.txt
in the 1266/
directory. Please remove that.
I have added a few more suggestions to improve the PR. There are some recurring issues:
- Please don't use
<br>
. - Please use a single space after a punctuation like
,
,.
,:
etc. And before, usually don't add any spaces.
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Co-authored-by: Rafid Bin Mostofa <[email protected]>
@rebornplusplus I am requesting you to check it again . Changes done based on your feedback . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
super easy explanation