Skip to content

[Update] Domain status enum #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

hzoppetti
Copy link
Contributor

updated domain status enum to only include active and disabled

@nmelehan
Copy link
Contributor

@cschreep Hola! This should be ready for your review, though I do have one question for you--

Technically, it looks like the API code updates only get rid of setting the edit_mode status on the API and doesn't have any bearing on whether a domain with status of edit_mode could be read from the API, if that were to exist. Would you prefer it if we set edit_mode to read-only instead of getting rid of it? Or, because we're looking to phase it out in general, should we just stick to getting rid of it entirely?

@nmelehan nmelehan requested a review from yoshizzle January 10, 2020 20:02
@cschreep
Copy link

@nmelehan the request for this change suggests that we don't want it at all anymore, so we should stick with getting rid of it entirely

@nmelehan nmelehan requested a review from sagesyr January 10, 2020 20:20
@nmelehan nmelehan merged commit ed255a8 into linode:development Jan 13, 2020
LBGarber pushed a commit to LBGarber/linode-api-docs that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants