Skip to content

Commit 7cf5e60

Browse files
ziyao233Sasha Levin
authored andcommitted
platform/loongarch: laptop: Unregister generic_sub_drivers on exit
commit f78fb25 upstream. Without correct unregisteration, ACPI notify handlers and the platform drivers installed by generic_subdriver_init() will become dangling references after removing the loongson_laptop module, triggering various kernel faults when a hotkey is sent or at kernel shutdown. Cc: [email protected] Fixes: 6246ed0 ("LoongArch: Add ACPI-based generic laptop driver") Signed-off-by: Yao Zi <[email protected]> Signed-off-by: Huacai Chen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 9832ec7 commit 7cf5e60

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

drivers/platform/loongarch/loongson-laptop.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -611,11 +611,17 @@ static int __init generic_acpi_laptop_init(void)
611611

612612
static void __exit generic_acpi_laptop_exit(void)
613613
{
614+
int i;
615+
614616
if (generic_inputdev) {
615-
if (input_device_registered)
616-
input_unregister_device(generic_inputdev);
617-
else
617+
if (!input_device_registered) {
618618
input_free_device(generic_inputdev);
619+
} else {
620+
input_unregister_device(generic_inputdev);
621+
622+
for (i = 0; i < ARRAY_SIZE(generic_sub_drivers); i++)
623+
generic_subdriver_exit(&generic_sub_drivers[i]);
624+
}
619625
}
620626
}
621627

0 commit comments

Comments
 (0)