Skip to content

Commit 0617a76

Browse files
sean-jcbonzini
authored andcommitted
KVM: x86: Rename virtualization {en,dis}abling APIs to match common KVM
Rename x86's the per-CPU vendor hooks used to enable virtualization in hardware to align with the recently renamed arch hooks. No functional change intended. Signed-off-by: Sean Christopherson <[email protected]> Reviewed-by: Kai Huang <[email protected]> Message-ID: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 5381eca commit 0617a76

File tree

7 files changed

+27
-27
lines changed

7 files changed

+27
-27
lines changed

arch/x86/include/asm/kvm-x86-ops.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ BUILD_BUG_ON(1)
1414
* be __static_call_return0.
1515
*/
1616
KVM_X86_OP(check_processor_compatibility)
17-
KVM_X86_OP(hardware_enable)
18-
KVM_X86_OP(hardware_disable)
17+
KVM_X86_OP(enable_virtualization_cpu)
18+
KVM_X86_OP(disable_virtualization_cpu)
1919
KVM_X86_OP(hardware_unsetup)
2020
KVM_X86_OP(has_emulated_msr)
2121
KVM_X86_OP(vcpu_after_set_cpuid)

arch/x86/include/asm/kvm_host.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1629,8 +1629,8 @@ struct kvm_x86_ops {
16291629

16301630
int (*check_processor_compatibility)(void);
16311631

1632-
int (*hardware_enable)(void);
1633-
void (*hardware_disable)(void);
1632+
int (*enable_virtualization_cpu)(void);
1633+
void (*disable_virtualization_cpu)(void);
16341634
void (*hardware_unsetup)(void);
16351635
bool (*has_emulated_msr)(struct kvm *kvm, u32 index);
16361636
void (*vcpu_after_set_cpuid)(struct kvm_vcpu *vcpu);

arch/x86/kvm/svm/svm.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -592,14 +592,14 @@ static inline void kvm_cpu_svm_disable(void)
592592
}
593593
}
594594

595-
static void svm_emergency_disable(void)
595+
static void svm_emergency_disable_virtualization_cpu(void)
596596
{
597597
kvm_rebooting = true;
598598

599599
kvm_cpu_svm_disable();
600600
}
601601

602-
static void svm_hardware_disable(void)
602+
static void svm_disable_virtualization_cpu(void)
603603
{
604604
/* Make sure we clean up behind us */
605605
if (tsc_scaling)
@@ -610,7 +610,7 @@ static void svm_hardware_disable(void)
610610
amd_pmu_disable_virt();
611611
}
612612

613-
static int svm_hardware_enable(void)
613+
static int svm_enable_virtualization_cpu(void)
614614
{
615615

616616
struct svm_cpu_data *sd;
@@ -1533,7 +1533,7 @@ static void svm_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
15331533
* TSC_AUX is always virtualized for SEV-ES guests when the feature is
15341534
* available. The user return MSR support is not required in this case
15351535
* because TSC_AUX is restored on #VMEXIT from the host save area
1536-
* (which has been initialized in svm_hardware_enable()).
1536+
* (which has been initialized in svm_enable_virtualization_cpu()).
15371537
*/
15381538
if (likely(tsc_aux_uret_slot >= 0) &&
15391539
(!boot_cpu_has(X86_FEATURE_V_TSC_AUX) || !sev_es_guest(vcpu->kvm)))
@@ -3132,7 +3132,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr)
31323132
* feature is available. The user return MSR support is not
31333133
* required in this case because TSC_AUX is restored on #VMEXIT
31343134
* from the host save area (which has been initialized in
3135-
* svm_hardware_enable()).
3135+
* svm_enable_virtualization_cpu()).
31363136
*/
31373137
if (boot_cpu_has(X86_FEATURE_V_TSC_AUX) && sev_es_guest(vcpu->kvm))
31383138
break;
@@ -4980,8 +4980,8 @@ static struct kvm_x86_ops svm_x86_ops __initdata = {
49804980
.check_processor_compatibility = svm_check_processor_compat,
49814981

49824982
.hardware_unsetup = svm_hardware_unsetup,
4983-
.hardware_enable = svm_hardware_enable,
4984-
.hardware_disable = svm_hardware_disable,
4983+
.enable_virtualization_cpu = svm_enable_virtualization_cpu,
4984+
.disable_virtualization_cpu = svm_disable_virtualization_cpu,
49854985
.has_emulated_msr = svm_has_emulated_msr,
49864986

49874987
.vcpu_create = svm_vcpu_create,
@@ -5411,7 +5411,7 @@ static void __svm_exit(void)
54115411
{
54125412
kvm_x86_vendor_exit();
54135413

5414-
cpu_emergency_unregister_virt_callback(svm_emergency_disable);
5414+
cpu_emergency_unregister_virt_callback(svm_emergency_disable_virtualization_cpu);
54155415
}
54165416

54175417
static int __init svm_init(void)
@@ -5427,7 +5427,7 @@ static int __init svm_init(void)
54275427
if (r)
54285428
return r;
54295429

5430-
cpu_emergency_register_virt_callback(svm_emergency_disable);
5430+
cpu_emergency_register_virt_callback(svm_emergency_disable_virtualization_cpu);
54315431

54325432
/*
54335433
* Common KVM initialization _must_ come last, after this, /dev/kvm is

arch/x86/kvm/vmx/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ struct kvm_x86_ops vt_x86_ops __initdata = {
2323

2424
.hardware_unsetup = vmx_hardware_unsetup,
2525

26-
.hardware_enable = vmx_hardware_enable,
27-
.hardware_disable = vmx_hardware_disable,
26+
.enable_virtualization_cpu = vmx_enable_virtualization_cpu,
27+
.disable_virtualization_cpu = vmx_disable_virtualization_cpu,
2828
.has_emulated_msr = vmx_has_emulated_msr,
2929

3030
.vm_size = sizeof(struct kvm_vmx),

arch/x86/kvm/vmx/vmx.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ static int kvm_cpu_vmxoff(void)
755755
return -EIO;
756756
}
757757

758-
static void vmx_emergency_disable(void)
758+
static void vmx_emergency_disable_virtualization_cpu(void)
759759
{
760760
int cpu = raw_smp_processor_id();
761761
struct loaded_vmcs *v;
@@ -2844,7 +2844,7 @@ static int kvm_cpu_vmxon(u64 vmxon_pointer)
28442844
return -EFAULT;
28452845
}
28462846

2847-
int vmx_hardware_enable(void)
2847+
int vmx_enable_virtualization_cpu(void)
28482848
{
28492849
int cpu = raw_smp_processor_id();
28502850
u64 phys_addr = __pa(per_cpu(vmxarea, cpu));
@@ -2881,7 +2881,7 @@ static void vmclear_local_loaded_vmcss(void)
28812881
__loaded_vmcs_clear(v);
28822882
}
28832883

2884-
void vmx_hardware_disable(void)
2884+
void vmx_disable_virtualization_cpu(void)
28852885
{
28862886
vmclear_local_loaded_vmcss();
28872887

@@ -8584,7 +8584,7 @@ static void __vmx_exit(void)
85848584
{
85858585
allow_smaller_maxphyaddr = false;
85868586

8587-
cpu_emergency_unregister_virt_callback(vmx_emergency_disable);
8587+
cpu_emergency_unregister_virt_callback(vmx_emergency_disable_virtualization_cpu);
85888588

85898589
vmx_cleanup_l1d_flush();
85908590
}
@@ -8632,7 +8632,7 @@ static int __init vmx_init(void)
86328632
pi_init_cpu(cpu);
86338633
}
86348634

8635-
cpu_emergency_register_virt_callback(vmx_emergency_disable);
8635+
cpu_emergency_register_virt_callback(vmx_emergency_disable_virtualization_cpu);
86368636

86378637
vmx_check_vmcs12_offsets();
86388638

arch/x86/kvm/vmx/x86_ops.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ extern struct kvm_x86_init_ops vt_init_ops __initdata;
1313

1414
void vmx_hardware_unsetup(void);
1515
int vmx_check_processor_compat(void);
16-
int vmx_hardware_enable(void);
17-
void vmx_hardware_disable(void);
16+
int vmx_enable_virtualization_cpu(void);
17+
void vmx_disable_virtualization_cpu(void);
1818
int vmx_vm_init(struct kvm *kvm);
1919
void vmx_vm_destroy(struct kvm *kvm);
2020
int vmx_vcpu_precreate(struct kvm *kvm);

arch/x86/kvm/x86.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9749,7 +9749,7 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops)
97499749

97509750
guard(mutex)(&vendor_module_lock);
97519751

9752-
if (kvm_x86_ops.hardware_enable) {
9752+
if (kvm_x86_ops.enable_virtualization_cpu) {
97539753
pr_err("already loaded vendor module '%s'\n", kvm_x86_ops.name);
97549754
return -EEXIST;
97559755
}
@@ -9876,7 +9876,7 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops)
98769876
return 0;
98779877

98789878
out_unwind_ops:
9879-
kvm_x86_ops.hardware_enable = NULL;
9879+
kvm_x86_ops.enable_virtualization_cpu = NULL;
98809880
kvm_x86_call(hardware_unsetup)();
98819881
out_mmu_exit:
98829882
kvm_mmu_vendor_module_exit();
@@ -9917,7 +9917,7 @@ void kvm_x86_vendor_exit(void)
99179917
WARN_ON(static_branch_unlikely(&kvm_xen_enabled.key));
99189918
#endif
99199919
mutex_lock(&vendor_module_lock);
9920-
kvm_x86_ops.hardware_enable = NULL;
9920+
kvm_x86_ops.enable_virtualization_cpu = NULL;
99219921
mutex_unlock(&vendor_module_lock);
99229922
}
99239923
EXPORT_SYMBOL_GPL(kvm_x86_vendor_exit);
@@ -12528,7 +12528,7 @@ int kvm_arch_enable_virtualization_cpu(void)
1252812528
if (ret)
1252912529
return ret;
1253012530

12531-
ret = kvm_x86_call(hardware_enable)();
12531+
ret = kvm_x86_call(enable_virtualization_cpu)();
1253212532
if (ret != 0)
1253312533
return ret;
1253412534

@@ -12610,7 +12610,7 @@ int kvm_arch_enable_virtualization_cpu(void)
1261012610

1261112611
void kvm_arch_disable_virtualization_cpu(void)
1261212612
{
12613-
kvm_x86_call(hardware_disable)();
12613+
kvm_x86_call(disable_virtualization_cpu)();
1261412614
drop_user_return_notifiers();
1261512615
}
1261612616

0 commit comments

Comments
 (0)