Skip to content

Commit 09057ce

Browse files
rogerqdavem330
authored andcommitted
net: ethernet: ti: am65-cpsw: use return instead of goto in am65_cpsw_run_xdp()
In am65_cpsw_run_xdp() instead of goto followed by return, simply return. Signed-off-by: Roger Quadros <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1ae26bf commit 09057ce

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

drivers/net/ethernet/ti/am65-cpsw-nuss.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,8 +1193,7 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow,
11931193

11941194
switch (act) {
11951195
case XDP_PASS:
1196-
ret = AM65_CPSW_XDP_PASS;
1197-
goto out;
1196+
return AM65_CPSW_XDP_PASS;
11981197
case XDP_TX:
11991198
tx_chn = &common->tx_chns[cpu % AM65_CPSW_MAX_QUEUES];
12001199
netif_txq = netdev_get_tx_queue(ndev, tx_chn->id);
@@ -1213,15 +1212,13 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow,
12131212
goto drop;
12141213

12151214
dev_sw_netstats_rx_add(ndev, pkt_len);
1216-
ret = AM65_CPSW_XDP_CONSUMED;
1217-
goto out;
1215+
return AM65_CPSW_XDP_CONSUMED;
12181216
case XDP_REDIRECT:
12191217
if (unlikely(xdp_do_redirect(ndev, xdp, prog)))
12201218
goto drop;
12211219

12221220
dev_sw_netstats_rx_add(ndev, pkt_len);
1223-
ret = AM65_CPSW_XDP_REDIRECT;
1224-
goto out;
1221+
return AM65_CPSW_XDP_REDIRECT;
12251222
default:
12261223
bpf_warn_invalid_xdp_action(ndev, prog, act);
12271224
fallthrough;
@@ -1236,7 +1233,6 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow,
12361233
page = virt_to_head_page(xdp->data);
12371234
am65_cpsw_put_page(flow, page, true);
12381235

1239-
out:
12401236
return ret;
12411237
}
12421238

0 commit comments

Comments
 (0)