Skip to content

Commit 0cf3a14

Browse files
Amit Kumar Salechadavem330
authored andcommitted
qlcnic: fix netdev notifier in error path
netdev notifier are not unregistered if pci_register_driver fails. Signed-off-by: Amit Kumar Salecha <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0df170b commit 0cf3a14

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

drivers/net/qlcnic/qlcnic_main.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3451,6 +3451,7 @@ static struct pci_driver qlcnic_driver = {
34513451

34523452
static int __init qlcnic_init_module(void)
34533453
{
3454+
int ret;
34543455

34553456
printk(KERN_INFO "%s\n", qlcnic_driver_string);
34563457

@@ -3459,8 +3460,15 @@ static int __init qlcnic_init_module(void)
34593460
register_inetaddr_notifier(&qlcnic_inetaddr_cb);
34603461
#endif
34613462

3463+
ret = pci_register_driver(&qlcnic_driver);
3464+
if (ret) {
3465+
#ifdef CONFIG_INET
3466+
unregister_inetaddr_notifier(&qlcnic_inetaddr_cb);
3467+
unregister_netdevice_notifier(&qlcnic_netdev_cb);
3468+
#endif
3469+
}
34623470

3463-
return pci_register_driver(&qlcnic_driver);
3471+
return ret;
34643472
}
34653473

34663474
module_init(qlcnic_init_module);

0 commit comments

Comments
 (0)