Skip to content

Commit 270fe2c

Browse files
Chen Zhoudavem330
authored andcommitted
net/wan/fsl_ucc_hdlc: remove set but not used variables 'ut_info' and 'ret'
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wan/fsl_ucc_hdlc.c: In function ucc_hdlc_irq_handler: drivers/net/wan/fsl_ucc_hdlc.c:643:23: warning: variable ut_info set but not used [-Wunused-but-set-variable] drivers/net/wan/fsl_ucc_hdlc.c: In function uhdlc_suspend: drivers/net/wan/fsl_ucc_hdlc.c:880:23: warning: variable ut_info set but not used [-Wunused-but-set-variable] drivers/net/wan/fsl_ucc_hdlc.c: In function uhdlc_resume: drivers/net/wan/fsl_ucc_hdlc.c:925:6: warning: variable ret set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot <[email protected]> Signed-off-by: Chen Zhou <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1b3b289 commit 270fe2c

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

drivers/net/wan/fsl_ucc_hdlc.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -635,11 +635,9 @@ static irqreturn_t ucc_hdlc_irq_handler(int irq, void *dev_id)
635635
struct ucc_hdlc_private *priv = (struct ucc_hdlc_private *)dev_id;
636636
struct net_device *dev = priv->ndev;
637637
struct ucc_fast_private *uccf;
638-
struct ucc_tdm_info *ut_info;
639638
u32 ucce;
640639
u32 uccm;
641640

642-
ut_info = priv->ut_info;
643641
uccf = priv->uccf;
644642

645643
ucce = ioread32be(uccf->p_ucce);
@@ -872,7 +870,6 @@ static void resume_clk_config(struct ucc_hdlc_private *priv)
872870
static int uhdlc_suspend(struct device *dev)
873871
{
874872
struct ucc_hdlc_private *priv = dev_get_drvdata(dev);
875-
struct ucc_tdm_info *ut_info;
876873
struct ucc_fast __iomem *uf_regs;
877874

878875
if (!priv)
@@ -884,7 +881,6 @@ static int uhdlc_suspend(struct device *dev)
884881
netif_device_detach(priv->ndev);
885882
napi_disable(&priv->napi);
886883

887-
ut_info = priv->ut_info;
888884
uf_regs = priv->uf_regs;
889885

890886
/* backup gumr guemr*/
@@ -917,7 +913,7 @@ static int uhdlc_resume(struct device *dev)
917913
struct ucc_fast __iomem *uf_regs;
918914
struct ucc_fast_private *uccf;
919915
struct ucc_fast_info *uf_info;
920-
int ret, i;
916+
int i;
921917
u32 cecr_subblock;
922918
u16 bd_status;
923919

@@ -962,16 +958,16 @@ static int uhdlc_resume(struct device *dev)
962958

963959
/* Write to QE CECR, UCCx channel to Stop Transmission */
964960
cecr_subblock = ucc_fast_get_qe_cr_subblock(uf_info->ucc_num);
965-
ret = qe_issue_cmd(QE_STOP_TX, cecr_subblock,
966-
(u8)QE_CR_PROTOCOL_UNSPECIFIED, 0);
961+
qe_issue_cmd(QE_STOP_TX, cecr_subblock,
962+
(u8)QE_CR_PROTOCOL_UNSPECIFIED, 0);
967963

968964
/* Set UPSMR normal mode */
969965
iowrite32be(0, &uf_regs->upsmr);
970966

971967
/* init parameter base */
972968
cecr_subblock = ucc_fast_get_qe_cr_subblock(uf_info->ucc_num);
973-
ret = qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, cecr_subblock,
974-
QE_CR_PROTOCOL_UNSPECIFIED, priv->ucc_pram_offset);
969+
qe_issue_cmd(QE_ASSIGN_PAGE_TO_DEVICE, cecr_subblock,
970+
QE_CR_PROTOCOL_UNSPECIFIED, priv->ucc_pram_offset);
975971

976972
priv->ucc_pram = (struct ucc_hdlc_param __iomem *)
977973
qe_muram_addr(priv->ucc_pram_offset);

0 commit comments

Comments
 (0)