Skip to content

Commit 2dd4d82

Browse files
edumazetdavem330
authored andcommitted
net: remove dev_base_lock from do_setlink()
We hold RTNL here, and dev->link_mode readers already are using READ_ONCE(). Signed-off-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 6a2968e commit 2dd4d82

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

net/core/rtnetlink.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2961,11 +2961,9 @@ static int do_setlink(const struct sk_buff *skb,
29612961
if (tb[IFLA_LINKMODE]) {
29622962
unsigned char value = nla_get_u8(tb[IFLA_LINKMODE]);
29632963

2964-
write_lock(&dev_base_lock);
29652964
if (dev->link_mode ^ value)
29662965
status |= DO_SETLINK_NOTIFY;
29672966
WRITE_ONCE(dev->link_mode, value);
2968-
write_unlock(&dev_base_lock);
29692967
}
29702968

29712969
if (tb[IFLA_VFINFO_LIST]) {

0 commit comments

Comments
 (0)