igc: Fix static checker warning

aneftin · anguy11 · commit 360d749e0c8e · 2020-07-27T08:49:32.000-07:00
drivers/net/ethernet/intel/igc/igc_mac.c:424 igc_check_for_copper_link() error: uninitialized symbol 'link'. This patch come to fix this warning and initialize the 'link' symbol. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Fixes: 707abf0 ("igc: Add initial LTR support") Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
@@ -355,8 +355,8 @@ void igc_rar_set(struct igc_hw *hw, u8 *addr, u32 index)
 s32 igc_check_for_copper_link(struct igc_hw *hw)
 {
 	struct igc_mac_info *mac = &hw->mac;
+	bool link = false;
 	s32 ret_val;
-	bool link;
 
 	/* We only want to go out to the PHY registers to see if Auto-Neg
 	 * has completed and/or if our link status has changed.  The

Original file line number	Diff line number	Diff line change
`@@ -355,8 +355,8 @@ void igc_rar_set(struct igc_hw hw, u8 addr, u32 index)`
`355`	`355`	`s32 igc_check_for_copper_link(struct igc_hw *hw)`
`356`	`356`	`{`
`357`	`357`	`struct igc_mac_info *mac = &hw->mac;`
	`358`	`+ bool link = false;`
`358`	`359`	`s32 ret_val;`
`359`		`- bool link;`
`360`	`360`
`361`	`361`	`/* We only want to go out to the PHY registers to see if Auto-Neg`
`362`	`362`	`* has completed and/or if our link status has changed. The`