Skip to content

Commit 3d9e133

Browse files
MikeLooijmansdavem330
authored andcommitted
devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings
The KSZ9031 skew registers contain an offset, the chip's default value is "neutral" which does not add any skew. Programming a 0 into a skew property will actually set it the maximal negative adjustment and not to a neutral position as one would expect. Explain this situation in the devicetree binding documentation and list the settings that the chip considers neutral. Changing the implementation to accept negative values would have been a better solution, but would break existing configurations. Signed-off-by: Mike Looijmans <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0a55c12 commit 3d9e133

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Documentation/devicetree/bindings/net/micrel-ksz90x1.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,17 @@ KSZ9031:
3434

3535
All skew control options are specified in picoseconds. The minimum
3636
value is 0, and the maximum is property-dependent. The increment
37-
step is 60ps.
37+
step is 60ps. The default value is the neutral setting, so setting
38+
rxc-skew-ps=<0> actually results in -900 picoseconds adjustment.
3839

3940
Optional properties:
4041

41-
Maximum value of 1860:
42+
Maximum value of 1860, default value 900:
4243

4344
- rxc-skew-ps : Skew control of RX clock pad
4445
- txc-skew-ps : Skew control of TX clock pad
4546

46-
Maximum value of 900:
47+
Maximum value of 900, default value 420:
4748

4849
- rxdv-skew-ps : Skew control of RX CTL pad
4950
- txen-skew-ps : Skew control of TX CTL pad

0 commit comments

Comments
 (0)