swsmu/amdgpu_smu: Fix the wrong if-condition

Yu Songping · alexdeucher · commit 484d7dcc709d · 2022-11-29T11:03:37.000-05:00
The logical operator '&amp;&amp;' will make
smu-&gt;ppt_funcs-&gt;set_gfx_power_up_by_imu segment fault when
smu-&gt;ppt_funcs is NULL.

Signed-off-by: Yu Songping &lt;yusongping@huawei.com&gt;
Reviewed-by: Evan Quan &lt;evan.quan@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -161,7 +161,7 @@ int smu_get_dpm_freq_range(struct smu_context *smu,
 
 int smu_set_gfx_power_up_by_imu(struct smu_context *smu)
 {
-	if (!smu->ppt_funcs && !smu->ppt_funcs->set_gfx_power_up_by_imu)
+	if (!smu->ppt_funcs || !smu->ppt_funcs->set_gfx_power_up_by_imu)
 		return -EOPNOTSUPP;
 
 	return smu->ppt_funcs->set_gfx_power_up_by_imu(smu);

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ int smu_get_dpm_freq_range(struct smu_context *smu,`
`161`	`161`
`162`	`162`	`int smu_set_gfx_power_up_by_imu(struct smu_context *smu)`
`163`	`163`	`{`
`164`		`- if (!smu->ppt_funcs && !smu->ppt_funcs->set_gfx_power_up_by_imu)`
	`164`	`+ if (!smu->ppt_funcs \|\| !smu->ppt_funcs->set_gfx_power_up_by_imu)`
`165`	`165`	`return -EOPNOTSUPP;`
`166`	`166`
`167`	`167`	`return smu->ppt_funcs->set_gfx_power_up_by_imu(smu);`