Skip to content

Commit 71d6fdb

Browse files
kubalewskianguy11
authored andcommitted
i40e: Fix firmware LLDP agent related warning
Make warning meaningful for the user. Previously the trace: "Starting FW LLDP agent failed: error: I40E_ERR_ADMIN_QUEUE_ERROR, I40E_AQ_RC_EAGAIN" was produced when user tried to start Firmware LLDP agent, just after it was stopped with sequence: ethtool --set-priv-flags <dev> disable-fw-lldp on ethtool --set-priv-flags <dev> disable-fw-lldp off (without any delay between the commands) At that point the firmware is still processing stop command, the behavior is expected. Fixes: c1041d0 ("i40e: Missing response checks in driver when starting/stopping FW LLDP") Signed-off-by: Aleksandr Loktionov <[email protected]> Signed-off-by: Arkadiusz Kubalewski <[email protected]> Tested-by: Imam Hassan Reza Biswas <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 65662a8 commit 71d6fdb

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5294,6 +5294,10 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags)
52945294
dev_warn(&pf->pdev->dev,
52955295
"Device configuration forbids SW from starting the LLDP agent.\n");
52965296
return -EINVAL;
5297+
case I40E_AQ_RC_EAGAIN:
5298+
dev_warn(&pf->pdev->dev,
5299+
"Stop FW LLDP agent command is still being processed, please try again in a second.\n");
5300+
return -EBUSY;
52975301
default:
52985302
dev_warn(&pf->pdev->dev,
52995303
"Starting FW LLDP agent failed: error: %s, %s\n",

0 commit comments

Comments
 (0)