Skip to content

Commit 7ec8721

Browse files
ffainellidavem330
authored andcommitted
net: ethtool: disambiguate XCVR_* meaning
Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and Ethernet MAC in a different package/die). Most if not all of the drivers setting their transceiver type already do it the way the comment describes it. Signed-off-by: Florian Fainelli <[email protected]> Reviewed-by: Ben Hutchings <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1010dcc commit 7ec8721

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/uapi/linux/ethtool.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -993,8 +993,8 @@ enum ethtool_sfeatures_retval_bits {
993993
#define PORT_OTHER 0xff
994994

995995
/* Which transceiver to use. */
996-
#define XCVR_INTERNAL 0x00
997-
#define XCVR_EXTERNAL 0x01
996+
#define XCVR_INTERNAL 0x00 /* PHY and MAC are in the same package */
997+
#define XCVR_EXTERNAL 0x01 /* PHY and MAC are in different packages */
998998
#define XCVR_DUMMY1 0x02
999999
#define XCVR_DUMMY2 0x03
10001000
#define XCVR_DUMMY3 0x04

0 commit comments

Comments
 (0)