rbd: don't mess with a page vector in rbd_notify_op_lock()

idryomov · idryomov · commit 8ae0299a4b72 · 2020-04-13T08:55:49.000+02:00
rbd_notify_op_lock() isn't interested in a notify reply.  Instead of
accepting that page vector just to free it, have watch-notify code take
care of it.

Signed-off-by: Ilya Dryomov &lt;idryomov@gmail.com&gt;
Reviewed-by: Jason Dillaman &lt;dillaman@redhat.com&gt;
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
@@ -3754,11 +3754,7 @@ static int __rbd_notify_op_lock(struct rbd_device *rbd_dev,
 static void rbd_notify_op_lock(struct rbd_device *rbd_dev,
 			       enum rbd_notify_op notify_op)
 {
-	struct page **reply_pages;
-	size_t reply_len;
-
-	__rbd_notify_op_lock(rbd_dev, notify_op, &reply_pages, &reply_len);
-	ceph_release_page_vector(reply_pages, calc_pages_for(0, reply_len));
+	__rbd_notify_op_lock(rbd_dev, notify_op, NULL, NULL);
 }
 
 static void rbd_notify_acquired_lock(struct work_struct *work)

Original file line number	Diff line number	Diff line change
`@@ -3754,11 +3754,7 @@ static int __rbd_notify_op_lock(struct rbd_device *rbd_dev,`
`3754`	`3754`	`static void rbd_notify_op_lock(struct rbd_device *rbd_dev,`
`3755`	`3755`	`enum rbd_notify_op notify_op)`
`3756`	`3756`	`{`
`3757`		`- struct page **reply_pages;`
`3758`		`- size_t reply_len;`
`3759`		`-`
`3760`		`- __rbd_notify_op_lock(rbd_dev, notify_op, &reply_pages, &reply_len);`
`3761`		`- ceph_release_page_vector(reply_pages, calc_pages_for(0, reply_len));`
	`3757`	`+ __rbd_notify_op_lock(rbd_dev, notify_op, NULL, NULL);`
`3762`	`3758`	`}`
`3763`	`3759`
`3764`	`3760`	`static void rbd_notify_acquired_lock(struct work_struct *work)`