Skip to content

Commit 98fbebc

Browse files
cavagiudavem330
authored andcommitted
stmmac: remove BUS_MODE_DA
This is a very old and often unused option to configure a bit in a register inside the DMA. This support should not stay under Koption and should be extended for new chips too. This will be do later maybe via device-tree parameters. Also no performance impact when remove this setting on STi platforms. Signed-off-by: Giuseppe Cavallaro <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 50fb4f7 commit 98fbebc

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

drivers/net/ethernet/stmicro/stmmac/Kconfig

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,4 @@ config STMMAC_PCI
3737
D1215994A VIRTEX FPGA board.
3838

3939
If unsure, say N.
40-
41-
config STMMAC_DA
42-
bool "STMMAC DMA arbitration scheme"
43-
default n
44-
---help---
45-
Selecting this option, rx has priority over Tx (only for Giga
46-
Ethernet device).
47-
By default, the DMA arbitration scheme is based on Round-robin
48-
(rx:tx priority is 1:1).
49-
5040
endif

drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ static int dwmac1000_dma_init(void __iomem *ioaddr, int pbl, int fb, int mb,
7070
if (mb)
7171
value |= DMA_BUS_MODE_MB;
7272

73-
#ifdef CONFIG_STMMAC_DA
74-
value |= DMA_BUS_MODE_DA; /* Rx has priority over tx */
75-
#endif
76-
7773
if (atds)
7874
value |= DMA_BUS_MODE_ATDS;
7975

0 commit comments

Comments
 (0)