Skip to content

Commit 9b540e3

Browse files
Wayne Linalexdeucher
authored andcommitted
drm/amd/display: Copy AUX read reply data whenever length > 0
[Why] amdgpu_dm_process_dmub_aux_transfer_sync() should return all exact data reply from the sink side. Don't do the analysis job in it. [How] Remove unnecessary check condition AUX_TRANSACTION_REPLY_AUX_ACK. Fixes: ead08b9 ("drm/amd/display: Fix race condition in DPIA AUX transfer") Cc: Mario Limonciello <[email protected]> Cc: Alex Deucher <[email protected]> Reviewed-by: Ray Wu <[email protected]> Signed-off-by: Wayne Lin <[email protected]> Signed-off-by: Ray Wu <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 81b5c6f commit 9b540e3

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12853,8 +12853,7 @@ int amdgpu_dm_process_dmub_aux_transfer_sync(
1285312853
/* The reply is stored in the top nibble of the command. */
1285412854
payload->reply[0] = (adev->dm.dmub_notify->aux_reply.command >> 4) & 0xF;
1285512855

12856-
if (!payload->write && p_notify->aux_reply.length &&
12857-
(payload->reply[0] == AUX_TRANSACTION_REPLY_AUX_ACK))
12856+
if (!payload->write && p_notify->aux_reply.length)
1285812857
memcpy(payload->data, p_notify->aux_reply.data,
1285912858
p_notify->aux_reply.length);
1286012859

0 commit comments

Comments
 (0)