net/mlx4_en: Fix panic during reboot

Eugenia Emantayev · davem330 · commit 9d2afba05872 · 2016-10-29T16:23:48.000-04:00
Fix a kernel panic that occurs as a result of an asynchronous event handled in roce_gid_mgmt: mlx4_en_get_drvinfo is called and accesses freed resources. This happens in a shutdown flow only, since pci device is destroyed while netdevice is still alive. Fixes: c27a02c ("mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC") Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com> Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2201,6 +2201,7 @@ void mlx4_en_destroy_netdev(struct net_device *dev)
 
 	if (!shutdown)
 		free_netdev(dev);
+	dev->ethtool_ops = NULL;
 }
 
 static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)

Original file line number	Diff line number	Diff line change
`@@ -2201,6 +2201,7 @@ void mlx4_en_destroy_netdev(struct net_device *dev)`
`2201`	`2201`
`2202`	`2202`	`if (!shutdown)`
`2203`	`2203`	`free_netdev(dev);`
	`2204`	`+ dev->ethtool_ops = NULL;`
`2204`	`2205`	`}`
`2205`	`2206`
`2206`	`2207`	`static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)`