Skip to content

Commit 9e16bad

Browse files
lf-hernandezBenjamin Tissoires
authored andcommitted
hid: bpf: Fix grammar
* spelling fix: XBox -> Xbox, lowercase 'b' as per Microsoft branding * rephrase: paddle -> paddles, the controller itself has more than one paddle * rephrase: replace usage of "those" in favor of explicitly making reference to the paddles * grammatical fix: report -> reports, use present tense verb. * spelling fix: interpret * consistency: capitalize the first word in bullet points Signed-off-by: Luis Felipe Hernandez <[email protected]> Link: https://patch.msgid.link/[email protected] [bentiss: renamed the file into Xbox, not XBox] Signed-off-by: Benjamin Tissoires <[email protected]>
1 parent 33c0fb8 commit 9e16bad

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c renamed to drivers/hid/bpf/progs/Microsoft__Xbox-Elite-2.bpf.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,19 @@ HID_BPF_CONFIG(
1515
);
1616

1717
/*
18-
* When using the XBox Wireless Controller Elite 2 over Bluetooth,
19-
* the device exports the paddle on the back of the device as a single
18+
* When using the Xbox Wireless Controller Elite 2 over Bluetooth,
19+
* the device exports the paddles on the back of the device as a single
2020
* bitfield value of usage "Assign Selection".
2121
*
22-
* The kernel doesn't process those usages properly and report KEY_UNKNOWN
23-
* for it.
22+
* The kernel doesn't process the paddles usage properly and reports KEY_UNKNOWN.
2423
*
25-
* SDL doesn't know how to interprete that KEY_UNKNOWN and thus ignores the paddles.
24+
* SDL doesn't know how to interpret KEY_UNKNOWN and thus ignores the paddles.
2625
*
2726
* Given that over USB the kernel uses BTN_TRIGGER_HAPPY[5-8], we
28-
* can tweak the report descriptor to make the kernel interprete it properly:
29-
* - we need an application collection of gamepad (so we have to close the current
27+
* can tweak the report descriptor to make the kernel interpret it properly:
28+
* - We need an application collection of gamepad (so we have to close the current
3029
* Consumer Control one)
31-
* - we need to change the usage to be buttons from 0x15 to 0x18
30+
* - We need to change the usage to be buttons from 0x15 to 0x18
3231
*/
3332

3433
#define OFFSET_ASSIGN_SELECTION 211

0 commit comments

Comments
 (0)