net: freescale: ucc_geth: make ugeth_mac_ops be static const

Pei Xiao · kuba-moo · commit 9faaaef27c5d · 2025-02-18T18:08:18.000-08:00
sparse warning: sparse: symbol 'ugeth_mac_ops' was not declared. Should it be static. Add static to fix sparse warnings and add const. phylink_create() will accept a const struct. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/202502141128.9HfxcdIE-lkp@intel.com Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3408,7 +3408,7 @@ static int ucc_geth_parse_clock(struct device_node *np, const char *which,
 	return 0;
 }
 
-struct phylink_mac_ops ugeth_mac_ops = {
+static const struct phylink_mac_ops ugeth_mac_ops = {
 	.mac_link_up = ugeth_mac_link_up,
 	.mac_link_down = ugeth_mac_link_down,
 	.mac_config = ugeth_mac_config,

Original file line number	Diff line number	Diff line change
`@@ -3408,7 +3408,7 @@ static int ucc_geth_parse_clock(struct device_node np, const char which,`
`3408`	`3408`	`return 0;`
`3409`	`3409`	`}`
`3410`	`3410`
`3411`		`-struct phylink_mac_ops ugeth_mac_ops = {`
	`3411`	`+static const struct phylink_mac_ops ugeth_mac_ops = {`
`3412`	`3412`	`.mac_link_up = ugeth_mac_link_up,`
`3413`	`3413`	`.mac_link_down = ugeth_mac_link_down,`
`3414`	`3414`	`.mac_config = ugeth_mac_config,`