Skip to content

Commit a532149

Browse files
bebarinoEnric Balletbo i Serra
authored andcommitted
platform/chrome: wilco_ec: Add newlines to printks
printk messages all require newlines, or it looks very odd in the log when messages are not on different lines. Add them. Cc: Nick Crews <[email protected]> Cc: Daniel Campello <[email protected]> Cc: Enric Balletbo i Serra <[email protected]> Signed-off-by: Stephen Boyd <[email protected]> Signed-off-by: Enric Balletbo i Serra <[email protected]>
1 parent 3b0bfd3 commit a532149

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

drivers/platform/chrome/wilco_ec/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ static int wilco_ec_probe(struct platform_device *pdev)
9494

9595
ret = wilco_ec_add_sysfs(ec);
9696
if (ret < 0) {
97-
dev_err(dev, "Failed to create sysfs entries: %d", ret);
97+
dev_err(dev, "Failed to create sysfs entries: %d\n", ret);
9898
goto unregister_rtc;
9999
}
100100

drivers/platform/chrome/wilco_ec/keyboard_leds.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ static int send_kbbl_msg(struct wilco_ec_device *ec,
6969
ret = wilco_ec_mailbox(ec, &msg);
7070
if (ret < 0) {
7171
dev_err(ec->dev,
72-
"Failed sending keyboard LEDs command: %d", ret);
72+
"Failed sending keyboard LEDs command: %d\n", ret);
7373
return ret;
7474
}
7575

@@ -94,7 +94,7 @@ static int set_kbbl(struct wilco_ec_device *ec, enum led_brightness brightness)
9494

9595
if (response.status) {
9696
dev_err(ec->dev,
97-
"EC reported failure sending keyboard LEDs command: %d",
97+
"EC reported failure sending keyboard LEDs command: %d\n",
9898
response.status);
9999
return -EIO;
100100
}
@@ -147,7 +147,7 @@ static int kbbl_init(struct wilco_ec_device *ec)
147147

148148
if (response.status) {
149149
dev_err(ec->dev,
150-
"EC reported failure sending keyboard LEDs command: %d",
150+
"EC reported failure sending keyboard LEDs command: %d\n",
151151
response.status);
152152
return -EIO;
153153
}
@@ -179,7 +179,7 @@ int wilco_keyboard_leds_init(struct wilco_ec_device *ec)
179179
ret = kbbl_exist(ec, &leds_exist);
180180
if (ret < 0) {
181181
dev_err(ec->dev,
182-
"Failed checking keyboard LEDs support: %d", ret);
182+
"Failed checking keyboard LEDs support: %d\n", ret);
183183
return ret;
184184
}
185185
if (!leds_exist)

drivers/platform/chrome/wilco_ec/mailbox.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,13 +163,13 @@ static int wilco_ec_transfer(struct wilco_ec_device *ec,
163163
}
164164

165165
if (rs->data_size != EC_MAILBOX_DATA_SIZE) {
166-
dev_dbg(ec->dev, "unexpected packet size (%u != %u)",
166+
dev_dbg(ec->dev, "unexpected packet size (%u != %u)\n",
167167
rs->data_size, EC_MAILBOX_DATA_SIZE);
168168
return -EMSGSIZE;
169169
}
170170

171171
if (rs->data_size < msg->response_size) {
172-
dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)",
172+
dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)\n",
173173
rs->data_size, msg->response_size);
174174
return -EMSGSIZE;
175175
}

drivers/platform/chrome/wilco_ec/telemetry.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ static int telem_device_probe(struct platform_device *pdev)
367367
minor = ida_alloc_max(&telem_ida, TELEM_MAX_DEV-1, GFP_KERNEL);
368368
if (minor < 0) {
369369
error = minor;
370-
dev_err(&pdev->dev, "Failed to find minor number: %d", error);
370+
dev_err(&pdev->dev, "Failed to find minor number: %d\n", error);
371371
return error;
372372
}
373373

@@ -427,14 +427,14 @@ static int __init telem_module_init(void)
427427

428428
ret = class_register(&telem_class);
429429
if (ret) {
430-
pr_err(DRV_NAME ": Failed registering class: %d", ret);
430+
pr_err(DRV_NAME ": Failed registering class: %d\n", ret);
431431
return ret;
432432
}
433433

434434
/* Request the kernel for device numbers, starting with minor=0 */
435435
ret = alloc_chrdev_region(&dev_num, 0, TELEM_MAX_DEV, TELEM_DEV_NAME);
436436
if (ret) {
437-
pr_err(DRV_NAME ": Failed allocating dev numbers: %d", ret);
437+
pr_err(DRV_NAME ": Failed allocating dev numbers: %d\n", ret);
438438
goto destroy_class;
439439
}
440440
telem_major = MAJOR(dev_num);

0 commit comments

Comments
 (0)