Skip to content

Commit a7a05b1

Browse files
committed
kbuild: deb-pkg: add comment about future removal of KDEB_COMPRESS
'man dpkg-deb' describes as follows: DPKG_DEB_COMPRESSOR_TYPE Sets the compressor type to use (since dpkg 1.21.10). The -Z option overrides this value. When commit 1a7f0a3 ("builddeb: allow selection of .deb compressor") was applied, dpkg-deb did not support this environment variable. Later, dpkg commit c10aeffc6d71 ("dpkg-deb: Add support for DPKG_DEB_COMPRESSOR_TYPE/LEVEL") introduced support for DPKG_DEB_COMPRESSOR_TYPE, which provides the same functionality as KDEB_COMPRESS. KDEB_COMPRESS is still useful for users of older dpkg versions, but I would like to remove this redundant functionality in the future. This commit adds comments to notify users of the planned removal and to encourage migration to DPKG_DEB_COMPRESSOR_TYPE where possible. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 00e81f4 commit a7a05b1

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lib/Kconfig.debug

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,12 +335,12 @@ config DEBUG_INFO_COMPRESSED_ZLIB
335335
Compress the debug information using zlib. Requires GCC 5.0+ or Clang
336336
5.0+, binutils 2.26+, and zlib.
337337

338-
Users of dpkg-deb via scripts/package/builddeb may find an increase in
338+
Users of dpkg-deb via debian/rules may find an increase in
339339
size of their debug .deb packages with this config set, due to the
340340
debug info being compressed with zlib, then the object files being
341341
recompressed with a different compression scheme. But this is still
342-
preferable to setting $KDEB_COMPRESS to "none" which would be even
343-
larger.
342+
preferable to setting KDEB_COMPRESS or DPKG_DEB_COMPRESSOR_TYPE to
343+
"none" which would be even larger.
344344

345345
config DEBUG_INFO_COMPRESSED_ZSTD
346346
bool "Compress debugging information with zstd"

scripts/package/debian/rules

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ package = $($(@:binary-%=%-package))
4141
# which package is being processed in the build log.
4242
DH_OPTIONS = -p$(package)
4343

44+
# Note: future removal of KDEB_COMPRESS
45+
# dpkg-deb >= 1.21.10 supports the DPKG_DEB_COMPRESSOR_TYPE environment
46+
# variable, which provides the same functionality as KDEB_COMPRESS. The
47+
# KDEB_COMPRESS variable will be removed in the future.
4448
define binary
4549
$(Q)dh_testdir $(DH_OPTIONS)
4650
$(Q)dh_testroot $(DH_OPTIONS)

0 commit comments

Comments
 (0)