Skip to content

Commit ad649a1

Browse files
Bartosz Golaszewskidavem330
authored andcommitted
net: phy: aquantia: wait for FW reset before checking the vendor ID
Checking the firmware register before it complete the boot process makes no sense, it will report 0 even if FW is available from internal memory. Always wait for FW to boot before continuing or we'll unnecessarily try to load it from nvmem/filesystem and fail. Signed-off-by: Bartosz Golaszewski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 6631173 commit ad649a1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/phy/aquantia/aquantia_firmware.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,10 @@ int aqr_firmware_load(struct phy_device *phydev)
353353
{
354354
int ret;
355355

356+
ret = aqr_wait_reset_complete(phydev);
357+
if (ret)
358+
return ret;
359+
356360
/* Check if the firmware is not already loaded by pooling
357361
* the current version returned by the PHY. If 0 is returned,
358362
* no firmware is loaded.

0 commit comments

Comments
 (0)