Skip to content

Commit b5cd418

Browse files
Wayne Linalexdeucher
authored andcommitted
drm/amd/display: Validate mdoe under MST LCT=1 case as well
[Why & How] Currently in dm_dp_mst_is_port_support_mode(), when valdidating mode under dsc decoding at the last DP link config, we only validate the case when there is an UFP. However, if the MSTB LCT=1, there is no UFP. Under this case, use root_link_bw_in_kbps as the available bw to compare. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3720 Fixes: fa57924 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()") Cc: Mario Limonciello <[email protected]> Cc: Alex Deucher <[email protected]> Reviewed-by: Jerry Zuo <[email protected]> Signed-off-by: Wayne Lin <[email protected]> Signed-off-by: Tom Chung <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]> (cherry picked from commit a04d953) Cc: [email protected]
1 parent 11510e6 commit b5cd418

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1835,11 +1835,15 @@ enum dc_status dm_dp_mst_is_port_support_mode(
18351835
if (immediate_upstream_port) {
18361836
virtual_channel_bw_in_kbps = kbps_from_pbn(immediate_upstream_port->full_pbn);
18371837
virtual_channel_bw_in_kbps = min(root_link_bw_in_kbps, virtual_channel_bw_in_kbps);
1838-
if (bw_range.min_kbps > virtual_channel_bw_in_kbps) {
1839-
DRM_DEBUG_DRIVER("MST_DSC dsc decode at last link."
1840-
"Max dsc compression can't fit into MST available bw\n");
1841-
return DC_FAIL_BANDWIDTH_VALIDATE;
1842-
}
1838+
} else {
1839+
/* For topology LCT 1 case - only one mstb*/
1840+
virtual_channel_bw_in_kbps = root_link_bw_in_kbps;
1841+
}
1842+
1843+
if (bw_range.min_kbps > virtual_channel_bw_in_kbps) {
1844+
DRM_DEBUG_DRIVER("MST_DSC dsc decode at last link."
1845+
"Max dsc compression can't fit into MST available bw\n");
1846+
return DC_FAIL_BANDWIDTH_VALIDATE;
18431847
}
18441848
}
18451849

0 commit comments

Comments
 (0)