Skip to content

Commit c692964

Browse files
Ravikanth TunikiPaolo Abeni
authored andcommitted
dt-bindings: net: xlnx,axi-ethernet: Add missing reg minItems
Add missing reg minItems as based on current binding document only ethernet MAC IO space is a supported configuration. There is a bug in schema, current examples contain 64-bit addressing as well as 32-bit addressing. The schema validation does pass incidentally considering one 64-bit reg address as two 32-bit reg address entries. If we change axi_ethernet_eth1 example node reg addressing to 32-bit schema validation reports: Documentation/devicetree/bindings/net/xlnx,axi-ethernet.example.dtb: ethernet@40000000: reg: [[1073741824, 262144]] is too short To fix it add missing reg minItems constraints and to make things clearer stick to 32-bit addressing in examples. Fixes: cbb1ca6 ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml") Signed-off-by: Ravikanth Tuniki <[email protected]> Signed-off-by: Radhey Shyam Pandey <[email protected]> Acked-by: Conor Dooley <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent b63ad06 commit c692964

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ properties:
3434
and length of the AXI DMA controller IO space, unless
3535
axistream-connected is specified, in which case the reg
3636
attribute of the node referenced by it is used.
37+
minItems: 1
3738
maxItems: 2
3839

3940
interrupts:
@@ -181,7 +182,7 @@ examples:
181182
clock-names = "s_axi_lite_clk", "axis_clk", "ref_clk", "mgt_clk";
182183
clocks = <&axi_clk>, <&axi_clk>, <&pl_enet_ref_clk>, <&mgt_clk>;
183184
phy-mode = "mii";
184-
reg = <0x00 0x40000000 0x00 0x40000>;
185+
reg = <0x40000000 0x40000>;
185186
xlnx,rxcsum = <0x2>;
186187
xlnx,rxmem = <0x800>;
187188
xlnx,txcsum = <0x2>;

0 commit comments

Comments
 (0)