Skip to content

Commit c7c3a6d

Browse files
Christoph Hellwigkdave
authored andcommitted
btrfs: store a block_device in struct btrfs_ordered_extent
Store the block device instead of the gendisk in the btrfs_ordered_extent structure instead of acquiring a reference to it later. Note: this is from series removing bdgrab/bdput, btrfs is one of the last users. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 8949b9a commit c7c3a6d

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

fs/btrfs/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2992,7 +2992,7 @@ static int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent)
29922992
goto out;
29932993
}
29942994

2995-
if (ordered_extent->disk)
2995+
if (ordered_extent->bdev)
29962996
btrfs_rewrite_logical_zoned(ordered_extent);
29972997

29982998
btrfs_free_io_failure_record(inode, start, end);

fs/btrfs/ordered-data.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,6 @@ static int __btrfs_add_ordered_extent(struct btrfs_inode *inode, u64 file_offset
190190
entry->truncated_len = (u64)-1;
191191
entry->qgroup_rsv = ret;
192192
entry->physical = (u64)-1;
193-
entry->disk = NULL;
194-
entry->partno = (u8)-1;
195193

196194
ASSERT(type == BTRFS_ORDERED_REGULAR ||
197195
type == BTRFS_ORDERED_NOCOW ||

fs/btrfs/ordered-data.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,7 @@ struct btrfs_ordered_extent {
145145
* command in a workqueue context
146146
*/
147147
u64 physical;
148-
struct gendisk *disk;
149-
u8 partno;
148+
struct block_device *bdev;
150149
};
151150

152151
/*

fs/btrfs/zoned.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,8 +1349,7 @@ void btrfs_record_physical_zoned(struct inode *inode, u64 file_offset,
13491349
return;
13501350

13511351
ordered->physical = physical;
1352-
ordered->disk = bio->bi_bdev->bd_disk;
1353-
ordered->partno = bio->bi_bdev->bd_partno;
1352+
ordered->bdev = bio->bi_bdev;
13541353

13551354
btrfs_put_ordered_extent(ordered);
13561355
}
@@ -1362,18 +1361,16 @@ void btrfs_rewrite_logical_zoned(struct btrfs_ordered_extent *ordered)
13621361
struct extent_map_tree *em_tree;
13631362
struct extent_map *em;
13641363
struct btrfs_ordered_sum *sum;
1365-
struct block_device *bdev;
13661364
u64 orig_logical = ordered->disk_bytenr;
13671365
u64 *logical = NULL;
13681366
int nr, stripe_len;
13691367

13701368
/* Zoned devices should not have partitions. So, we can assume it is 0 */
1371-
ASSERT(ordered->partno == 0);
1372-
bdev = bdgrab(ordered->disk->part0);
1373-
if (WARN_ON(!bdev))
1369+
ASSERT(!bdev_is_partition(ordered->bdev));
1370+
if (WARN_ON(!ordered->bdev))
13741371
return;
13751372

1376-
if (WARN_ON(btrfs_rmap_block(fs_info, orig_logical, bdev,
1373+
if (WARN_ON(btrfs_rmap_block(fs_info, orig_logical, ordered->bdev,
13771374
ordered->physical, &logical, &nr,
13781375
&stripe_len)))
13791376
goto out;
@@ -1402,7 +1399,6 @@ void btrfs_rewrite_logical_zoned(struct btrfs_ordered_extent *ordered)
14021399

14031400
out:
14041401
kfree(logical);
1405-
bdput(bdev);
14061402
}
14071403

14081404
bool btrfs_check_meta_write_pointer(struct btrfs_fs_info *fs_info,

0 commit comments

Comments
 (0)