Skip to content

Commit cd72096

Browse files
committed
genetlink: remove linux/genetlink.h
genetlink.h is a shell of what used to be a combined uAPI and kernel header over a decade ago. It has fewer than 10 lines of code. Merge it into net/genetlink.h. In some ways it'd be better to keep the combined header under linux/ but it would make looking through git history harder. Acked-by: Sven Eckelmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent f97c9b5 commit cd72096

File tree

7 files changed

+12
-20
lines changed

7 files changed

+12
-20
lines changed

drivers/net/wireguard/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
#include <linux/init.h>
1616
#include <linux/module.h>
17-
#include <linux/genetlink.h>
17+
#include <net/genetlink.h>
1818
#include <net/rtnetlink.h>
1919

2020
static int __init wg_mod_init(void)

include/linux/genetlink.h

Lines changed: 0 additions & 14 deletions
This file was deleted.

include/linux/genl_magic_struct.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
#endif
1616

1717
#include <linux/args.h>
18-
#include <linux/genetlink.h>
1918
#include <linux/types.h>
19+
#include <net/genetlink.h>
2020

2121
extern int CONCATENATE(GENL_MAGIC_FAMILY, _genl_register)(void);
2222
extern void CONCATENATE(GENL_MAGIC_FAMILY, _genl_unregister)(void);

include/net/genetlink.h

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,20 @@
22
#ifndef __NET_GENERIC_NETLINK_H
33
#define __NET_GENERIC_NETLINK_H
44

5-
#include <linux/genetlink.h>
5+
#include <linux/net.h>
66
#include <net/netlink.h>
77
#include <net/net_namespace.h>
8+
#include <uapi/linux/genetlink.h>
89

910
#define GENLMSG_DEFAULT_SIZE (NLMSG_DEFAULT_SIZE - GENL_HDRLEN)
1011

12+
/* Non-parallel generic netlink requests are serialized by a global lock. */
13+
void genl_lock(void);
14+
void genl_unlock(void);
15+
16+
#define MODULE_ALIAS_GENL_FAMILY(family) \
17+
MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" family)
18+
1119
/* Binding to multicast group requires %CAP_NET_ADMIN */
1220
#define GENL_MCAST_CAP_NET_ADMIN BIT(0)
1321
/* Binding to multicast group requires %CAP_SYS_ADMIN */

net/batman-adv/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include <linux/crc32c.h>
1515
#include <linux/device.h>
1616
#include <linux/errno.h>
17-
#include <linux/genetlink.h>
1817
#include <linux/gfp.h>
1918
#include <linux/if_ether.h>
2019
#include <linux/if_vlan.h>
@@ -38,6 +37,7 @@
3837
#include <linux/string.h>
3938
#include <linux/workqueue.h>
4039
#include <net/dsfield.h>
40+
#include <net/genetlink.h>
4141
#include <net/rtnetlink.h>
4242
#include <uapi/linux/batadv_packet.h>
4343
#include <uapi/linux/batman_adv.h>

net/batman-adv/netlink.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <linux/cache.h>
1616
#include <linux/err.h>
1717
#include <linux/errno.h>
18-
#include <linux/genetlink.h>
1918
#include <linux/gfp.h>
2019
#include <linux/if_ether.h>
2120
#include <linux/if_vlan.h>

net/openvswitch/datapath.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <linux/delay.h>
1616
#include <linux/time.h>
1717
#include <linux/etherdevice.h>
18-
#include <linux/genetlink.h>
1918
#include <linux/kernel.h>
2019
#include <linux/kthread.h>
2120
#include <linux/mutex.h>

0 commit comments

Comments
 (0)