Skip to content

Commit d3ae5f4

Browse files
edumazetdavem330
authored andcommitted
net: rps: move received_rps field to a better location
Commit 14d898f ("dev: Move received_rps counter next to RPS members in softnet data") was unfortunate: received_rps is dirtied by a cpu and never read by other cpus in fast path. Its presence in the hot RPS cache line (shared by many cpus) is hurting RPS/RFS performance. Signed-off-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c62fdf5 commit d3ae5f4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/netdevice.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3204,6 +3204,7 @@ struct softnet_data {
32043204
struct softnet_data *rps_ipi_list;
32053205
#endif
32063206

3207+
unsigned int received_rps;
32073208
bool in_net_rx_action;
32083209
bool in_napi_threaded_poll;
32093210

@@ -3236,7 +3237,6 @@ struct softnet_data {
32363237
unsigned int cpu;
32373238
unsigned int input_queue_tail;
32383239
#endif
3239-
unsigned int received_rps;
32403240
struct sk_buff_head input_pkt_queue;
32413241
struct napi_struct backlog;
32423242

0 commit comments

Comments
 (0)