Skip to content

Commit d518691

Browse files
Sebastian Andrzej Siewiordavem330
authored andcommitted
amd-xgbe: Use __napi_schedule() in BH context
The driver uses __napi_schedule_irqoff() which is fine as long as it is invoked with disabled interrupts by everybody. Since the commit mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq context. This may lead to list corruption if another driver uses __napi_schedule_irqoff() in IRQ context. Use __napi_schedule() which safe to use from IRQ and softirq context. Fixes: 85b85c8 ("amd-xgbe: Re-issue interrupt if interrupt status not cleared") Signed-off-by: Sebastian Andrzej Siewior <[email protected]> Acked-by: Tom Lendacky <[email protected]> Cc: Tom Lendacky <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 05eab4f commit d518691

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ static void xgbe_isr_task(unsigned long data)
514514
xgbe_disable_rx_tx_ints(pdata);
515515

516516
/* Turn on polling */
517-
__napi_schedule_irqoff(&pdata->napi);
517+
__napi_schedule(&pdata->napi);
518518
}
519519
} else {
520520
/* Don't clear Rx/Tx status if doing per channel DMA

0 commit comments

Comments
 (0)