Skip to content

Commit db01165

Browse files
michichNipaLocal
authored andcommitted
idpf: don't skip over ethtool tcp-data-split setting
Disabling tcp-data-split on idpf silently fails: # ethtool -G $NETDEV tcp-data-split off # ethtool -g $NETDEV | grep 'TCP data split' TCP data split: on But it works if you also change 'tx' or 'rx': # ethtool -G $NETDEV tcp-data-split off tx 256 # ethtool -g $NETDEV | grep 'TCP data split' TCP data split: off The bug is in idpf_set_ringparam, where it takes a shortcut out if the TX and RX sizes are not changing. Fix it by checking also if the tcp-data-split setting remains unchanged. Only then can the soft reset be skipped. Fixes: 9b1aa3e ("idpf: add get/set for Ethtool's header split ringparam") Reported-by: Xu Du <[email protected]> Closes: https://issues.redhat.com/browse/RHEL-36182 Signed-off-by: Michal Schmidt <[email protected]> Reviewed-by: Alexander Lobakin <[email protected]> Signed-off-by: NipaLocal <nipa@local>
1 parent 2a3b6f3 commit db01165

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/intel/idpf/idpf_ethtool.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,8 @@ static int idpf_set_ringparam(struct net_device *netdev,
367367
new_tx_count);
368368

369369
if (new_tx_count == vport->txq_desc_count &&
370-
new_rx_count == vport->rxq_desc_count)
370+
new_rx_count == vport->rxq_desc_count &&
371+
kring->tcp_data_split == idpf_vport_get_hsplit(vport))
371372
goto unlock_mutex;
372373

373374
if (!idpf_vport_set_hsplit(vport, kring->tcp_data_split)) {

0 commit comments

Comments
 (0)