Skip to content

Commit e01b16a

Browse files
ecree-solarflaredavem330
ecree-solarflare
authored and
davem330
committed
sfc: remove EFX_BUG_ON_PARANOID, use EFX_WARN_ON_[ONCE_]PARANOID instead
Logically, EFX_BUG_ON_PARANOID can never be correct. For, BUG_ON should only be used if it is not possible to continue without potential harm; and since the non-DEBUG driver will continue regardless (as the BUG_ON is compiled out), clearly the BUG_ON cannot be needed in the DEBUG driver. So, replace every EFX_BUG_ON_PARANOID with either an EFX_WARN_ON_PARANOID or the newly defined EFX_WARN_ON_ONCE_PARANOID. Signed-off-by: Edward Cree <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 816fba3 commit e01b16a

File tree

13 files changed

+55
-56
lines changed

13 files changed

+55
-56
lines changed

‎drivers/net/ethernet/sfc/ef10.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2100,7 +2100,7 @@ static int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue,
21002100
u32 seqnum;
21012101
u32 mss;
21022102

2103-
EFX_BUG_ON_PARANOID(tx_queue->tso_version != 2);
2103+
EFX_WARN_ON_ONCE_PARANOID(tx_queue->tso_version != 2);
21042104

21052105
mss = skb_shinfo(skb)->gso_size;
21062106

‎drivers/net/ethernet/sfc/efx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ static int efx_probe_eventq(struct efx_channel *channel)
355355
/* Build an event queue with room for one event per tx and rx buffer,
356356
* plus some extra for link state events and MCDI completions. */
357357
entries = roundup_pow_of_two(efx->rxq_entries + efx->txq_entries + 128);
358-
EFX_BUG_ON_PARANOID(entries > EFX_MAX_EVQ_SIZE);
358+
EFX_WARN_ON_PARANOID(entries > EFX_MAX_EVQ_SIZE);
359359
channel->eventq_mask = max(entries, EFX_MIN_EVQ_SIZE) - 1;
360360

361361
return efx_nic_probe_eventq(channel);

‎drivers/net/ethernet/sfc/ethtool.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,12 +333,12 @@ static int efx_ethtool_fill_self_tests(struct efx_nic *efx,
333333
"core", 0, "registers", NULL);
334334

335335
if (efx->phy_op->run_tests != NULL) {
336-
EFX_BUG_ON_PARANOID(efx->phy_op->test_name == NULL);
336+
EFX_WARN_ON_PARANOID(efx->phy_op->test_name == NULL);
337337

338338
for (i = 0; true; ++i) {
339339
const char *name;
340340

341-
EFX_BUG_ON_PARANOID(i >= EFX_MAX_PHY_TESTS);
341+
EFX_WARN_ON_PARANOID(i >= EFX_MAX_PHY_TESTS);
342342
name = efx->phy_op->test_name(efx, i);
343343
if (name == NULL)
344344
break;

‎drivers/net/ethernet/sfc/farch.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ efx_init_special_buffer(struct efx_nic *efx, struct efx_special_buffer *buffer)
177177
dma_addr_t dma_addr;
178178
int i;
179179

180-
EFX_BUG_ON_PARANOID(!buffer->buf.addr);
180+
EFX_WARN_ON_PARANOID(!buffer->buf.addr);
181181

182182
/* Write buffer descriptors to NIC */
183183
for (i = 0; i < buffer->entries; i++) {
@@ -332,7 +332,7 @@ void efx_farch_tx_write(struct efx_tx_queue *tx_queue)
332332
txd = efx_tx_desc(tx_queue, write_ptr);
333333
++tx_queue->write_count;
334334

335-
EFX_BUG_ON_PARANOID(buffer->flags & EFX_TX_BUF_OPTION);
335+
EFX_WARN_ON_ONCE_PARANOID(buffer->flags & EFX_TX_BUF_OPTION);
336336

337337
/* Create TX descriptor ring entry */
338338
BUILD_BUG_ON(EFX_TX_BUF_CONT != 1);
@@ -2041,7 +2041,7 @@ efx_farch_filter_from_gen_spec(struct efx_farch_filter_spec *spec,
20412041
__be32 rhost, host1, host2;
20422042
__be16 rport, port1, port2;
20432043

2044-
EFX_BUG_ON_PARANOID(!(gen_spec->flags & EFX_FILTER_FLAG_RX));
2044+
EFX_WARN_ON_PARANOID(!(gen_spec->flags & EFX_FILTER_FLAG_RX));
20452045

20462046
if (gen_spec->ether_type != htons(ETH_P_IP))
20472047
return -EPROTONOSUPPORT;

‎drivers/net/ethernet/sfc/mcdi.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,14 @@ struct efx_mcdi_data {
129129

130130
static inline struct efx_mcdi_iface *efx_mcdi(struct efx_nic *efx)
131131
{
132-
EFX_BUG_ON_PARANOID(!efx->mcdi);
132+
EFX_WARN_ON_PARANOID(!efx->mcdi);
133133
return &efx->mcdi->iface;
134134
}
135135

136136
#ifdef CONFIG_SFC_MCDI_MON
137137
static inline struct efx_mcdi_mon *efx_mcdi_mon(struct efx_nic *efx)
138138
{
139-
EFX_BUG_ON_PARANOID(!efx->mcdi);
139+
EFX_WARN_ON_PARANOID(!efx->mcdi);
140140
return &efx->mcdi->hwmon;
141141
}
142142
#endif

‎drivers/net/ethernet/sfc/mcdi_mon.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ void efx_mcdi_sensor_event(struct efx_nic *efx, efx_qword_t *ev)
121121
}
122122
if (!name)
123123
name = "No sensor name available";
124-
EFX_BUG_ON_PARANOID(state >= ARRAY_SIZE(sensor_status_names));
124+
EFX_WARN_ON_PARANOID(state >= ARRAY_SIZE(sensor_status_names));
125125
state_txt = sensor_status_names[state];
126-
EFX_BUG_ON_PARANOID(hwmon_type >= EFX_HWMON_TYPES_COUNT);
126+
EFX_WARN_ON_PARANOID(hwmon_type >= EFX_HWMON_TYPES_COUNT);
127127
unit = efx_hwmon_unit[hwmon_type];
128128
if (!unit)
129129
unit = "";

‎drivers/net/ethernet/sfc/mcdi_port.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,7 @@ void efx_mcdi_process_link_change(struct efx_nic *efx, efx_qword_t *ev)
840840
u32 flags, fcntl, speed, lpa;
841841

842842
speed = EFX_QWORD_FIELD(*ev, MCDI_EVENT_LINKCHANGE_SPEED);
843-
EFX_BUG_ON_PARANOID(speed >= ARRAY_SIZE(efx_mcdi_event_link_speed));
843+
EFX_WARN_ON_PARANOID(speed >= ARRAY_SIZE(efx_mcdi_event_link_speed));
844844
speed = efx_mcdi_event_link_speed[speed];
845845

846846
flags = EFX_QWORD_FIELD(*ev, MCDI_EVENT_LINKCHANGE_LINK_FLAGS);

‎drivers/net/ethernet/sfc/net_driver.h

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
#define EFX_DRIVER_VERSION "4.1"
4545

4646
#ifdef DEBUG
47-
#define EFX_BUG_ON_PARANOID(x) BUG_ON(x)
47+
#define EFX_WARN_ON_ONCE_PARANOID(x) WARN_ON_ONCE(x)
4848
#define EFX_WARN_ON_PARANOID(x) WARN_ON(x)
4949
#else
50-
#define EFX_BUG_ON_PARANOID(x) do {} while (0)
50+
#define EFX_WARN_ON_ONCE_PARANOID(x) do {} while (0)
5151
#define EFX_WARN_ON_PARANOID(x) do {} while (0)
5252
#endif
5353

@@ -1409,7 +1409,7 @@ struct efx_nic_type {
14091409
static inline struct efx_channel *
14101410
efx_get_channel(struct efx_nic *efx, unsigned index)
14111411
{
1412-
EFX_BUG_ON_PARANOID(index >= efx->n_channels);
1412+
EFX_WARN_ON_ONCE_PARANOID(index >= efx->n_channels);
14131413
return efx->channel[index];
14141414
}
14151415

@@ -1430,8 +1430,8 @@ efx_get_channel(struct efx_nic *efx, unsigned index)
14301430
static inline struct efx_tx_queue *
14311431
efx_get_tx_queue(struct efx_nic *efx, unsigned index, unsigned type)
14321432
{
1433-
EFX_BUG_ON_PARANOID(index >= efx->n_tx_channels ||
1434-
type >= EFX_TXQ_TYPES);
1433+
EFX_WARN_ON_ONCE_PARANOID(index >= efx->n_tx_channels ||
1434+
type >= EFX_TXQ_TYPES);
14351435
return &efx->channel[efx->tx_channel_offset + index]->tx_queue[type];
14361436
}
14371437

@@ -1444,8 +1444,8 @@ static inline bool efx_channel_has_tx_queues(struct efx_channel *channel)
14441444
static inline struct efx_tx_queue *
14451445
efx_channel_get_tx_queue(struct efx_channel *channel, unsigned type)
14461446
{
1447-
EFX_BUG_ON_PARANOID(!efx_channel_has_tx_queues(channel) ||
1448-
type >= EFX_TXQ_TYPES);
1447+
EFX_WARN_ON_ONCE_PARANOID(!efx_channel_has_tx_queues(channel) ||
1448+
type >= EFX_TXQ_TYPES);
14491449
return &channel->tx_queue[type];
14501450
}
14511451

@@ -1482,7 +1482,7 @@ static inline bool efx_channel_has_rx_queue(struct efx_channel *channel)
14821482
static inline struct efx_rx_queue *
14831483
efx_channel_get_rx_queue(struct efx_channel *channel)
14841484
{
1485-
EFX_BUG_ON_PARANOID(!efx_channel_has_rx_queue(channel));
1485+
EFX_WARN_ON_ONCE_PARANOID(!efx_channel_has_rx_queue(channel));
14861486
return &channel->rx_queue;
14871487
}
14881488

@@ -1578,9 +1578,9 @@ efx_tx_queue_get_insert_buffer(const struct efx_tx_queue *tx_queue)
15781578
struct efx_tx_buffer *buffer =
15791579
__efx_tx_queue_get_insert_buffer(tx_queue);
15801580

1581-
EFX_BUG_ON_PARANOID(buffer->len);
1582-
EFX_BUG_ON_PARANOID(buffer->flags);
1583-
EFX_BUG_ON_PARANOID(buffer->unmap_len);
1581+
EFX_WARN_ON_ONCE_PARANOID(buffer->len);
1582+
EFX_WARN_ON_ONCE_PARANOID(buffer->flags);
1583+
EFX_WARN_ON_ONCE_PARANOID(buffer->unmap_len);
15841584

15851585
return buffer;
15861586
}

‎drivers/net/ethernet/sfc/ptp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,7 @@ static int efx_ptp_synchronize(struct efx_nic *efx, unsigned int num_readings)
835835
ACCESS_ONCE(*start) = 0;
836836
rc = efx_mcdi_rpc_start(efx, MC_CMD_PTP, synch_buf,
837837
MC_CMD_PTP_IN_SYNCHRONIZE_LEN);
838-
EFX_BUG_ON_PARANOID(rc);
838+
EFX_WARN_ON_ONCE_PARANOID(rc);
839839

840840
/* Wait for start from MCDI (or timeout) */
841841
timeout = jiffies + msecs_to_jiffies(MAX_SYNCHRONISE_WAIT_MS);

‎drivers/net/ethernet/sfc/rx.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ void efx_fast_push_rx_descriptors(struct efx_rx_queue *rx_queue, bool atomic)
335335

336336
/* Calculate current fill level, and exit if we don't need to fill */
337337
fill_level = (rx_queue->added_count - rx_queue->removed_count);
338-
EFX_BUG_ON_PARANOID(fill_level > rx_queue->efx->rxq_entries);
338+
EFX_WARN_ON_ONCE_PARANOID(fill_level > rx_queue->efx->rxq_entries);
339339
if (fill_level >= rx_queue->fast_fill_trigger)
340340
goto out;
341341

@@ -347,7 +347,7 @@ void efx_fast_push_rx_descriptors(struct efx_rx_queue *rx_queue, bool atomic)
347347

348348
batch_size = efx->rx_pages_per_batch * efx->rx_bufs_per_page;
349349
space = rx_queue->max_fill - fill_level;
350-
EFX_BUG_ON_PARANOID(space < batch_size);
350+
EFX_WARN_ON_ONCE_PARANOID(space < batch_size);
351351

352352
netif_vdbg(rx_queue->efx, rx_status, rx_queue->efx->net_dev,
353353
"RX queue %d fast-filling descriptor ring from"
@@ -475,7 +475,7 @@ static struct sk_buff *efx_rx_mk_skb(struct efx_channel *channel,
475475
return NULL;
476476
}
477477

478-
EFX_BUG_ON_PARANOID(rx_buf->len < hdr_len);
478+
EFX_WARN_ON_ONCE_PARANOID(rx_buf->len < hdr_len);
479479

480480
memcpy(skb->data + efx->rx_ip_align, eh - efx->rx_prefix_size,
481481
efx->rx_prefix_size + hdr_len);
@@ -682,7 +682,7 @@ int efx_probe_rx_queue(struct efx_rx_queue *rx_queue)
682682

683683
/* Create the smallest power-of-two aligned ring */
684684
entries = max(roundup_pow_of_two(efx->rxq_entries), EFX_MIN_DMAQ_SIZE);
685-
EFX_BUG_ON_PARANOID(entries > EFX_MAX_DMAQ_SIZE);
685+
EFX_WARN_ON_PARANOID(entries > EFX_MAX_DMAQ_SIZE);
686686
rx_queue->ptr_mask = entries - 1;
687687

688688
netif_dbg(efx, probe, efx->net_dev,

‎drivers/net/ethernet/sfc/siena.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -717,7 +717,7 @@ static void siena_mcdi_request(struct efx_nic *efx,
717717
unsigned int i;
718718
unsigned int inlen_dw = DIV_ROUND_UP(sdu_len, 4);
719719

720-
EFX_BUG_ON_PARANOID(hdr_len != 4);
720+
EFX_WARN_ON_PARANOID(hdr_len != 4);
721721

722722
efx_writed(efx, hdr, pdu);
723723

‎drivers/net/ethernet/sfc/tx.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ static void efx_tx_maybe_stop_queue(struct efx_tx_queue *txq1)
142142

143143
fill_level = max(txq1->insert_count - txq1->old_read_count,
144144
txq2->insert_count - txq2->old_read_count);
145-
EFX_BUG_ON_PARANOID(fill_level >= efx->txq_entries);
145+
EFX_WARN_ON_ONCE_PARANOID(fill_level >= efx->txq_entries);
146146
if (likely(fill_level < efx->txq_stop_thresh)) {
147147
smp_mb();
148148
if (likely(!efx->loopback_selftest))
@@ -158,7 +158,7 @@ static int efx_enqueue_skb_copy(struct efx_tx_queue *tx_queue,
158158
u8 *copy_buffer;
159159
int rc;
160160

161-
EFX_BUG_ON_PARANOID(copy_len > EFX_TX_CB_SIZE);
161+
EFX_WARN_ON_ONCE_PARANOID(copy_len > EFX_TX_CB_SIZE);
162162

163163
buffer = efx_tx_queue_get_insert_buffer(tx_queue);
164164

@@ -268,7 +268,7 @@ static void efx_skb_copy_bits_to_pio(struct efx_nic *efx, struct sk_buff *skb,
268268
kunmap_atomic(vaddr);
269269
}
270270

271-
EFX_BUG_ON_PARANOID(skb_shinfo(skb)->frag_list);
271+
EFX_WARN_ON_ONCE_PARANOID(skb_shinfo(skb)->frag_list);
272272
}
273273

274274
static int efx_enqueue_skb_pio(struct efx_tx_queue *tx_queue,
@@ -503,7 +503,7 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
503503
* size limit.
504504
*/
505505
if (segments) {
506-
EFX_BUG_ON_PARANOID(!tx_queue->handle_tso);
506+
EFX_WARN_ON_ONCE_PARANOID(!tx_queue->handle_tso);
507507
rc = tx_queue->handle_tso(tx_queue, skb, &data_mapped);
508508
if (rc == -EINVAL) {
509509
rc = efx_tx_tso_fallback(tx_queue, skb);
@@ -724,7 +724,7 @@ void efx_xmit_done(struct efx_tx_queue *tx_queue, unsigned int index)
724724
struct efx_tx_queue *txq2;
725725
unsigned int pkts_compl = 0, bytes_compl = 0;
726726

727-
EFX_BUG_ON_PARANOID(index > tx_queue->ptr_mask);
727+
EFX_WARN_ON_ONCE_PARANOID(index > tx_queue->ptr_mask);
728728

729729
efx_dequeue_buffers(tx_queue, index, &pkts_compl, &bytes_compl);
730730
tx_queue->pkts_compl += pkts_compl;
@@ -772,7 +772,7 @@ int efx_probe_tx_queue(struct efx_tx_queue *tx_queue)
772772

773773
/* Create the smallest power-of-two aligned ring */
774774
entries = max(roundup_pow_of_two(efx->txq_entries), EFX_MIN_DMAQ_SIZE);
775-
EFX_BUG_ON_PARANOID(entries > EFX_MAX_DMAQ_SIZE);
775+
EFX_WARN_ON_PARANOID(entries > EFX_MAX_DMAQ_SIZE);
776776
tx_queue->ptr_mask = entries - 1;
777777

778778
netif_dbg(efx, probe, efx->net_dev,

‎drivers/net/ethernet/sfc/tx_tso.c

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ static void efx_tx_queue_insert(struct efx_tx_queue *tx_queue,
109109
struct efx_tx_buffer *buffer;
110110
unsigned int dma_len;
111111

112-
EFX_BUG_ON_PARANOID(len <= 0);
112+
EFX_WARN_ON_ONCE_PARANOID(len <= 0);
113113

114114
while (1) {
115115
buffer = efx_tx_queue_get_insert_buffer(tx_queue);
116116
++tx_queue->insert_count;
117117

118-
EFX_BUG_ON_PARANOID(tx_queue->insert_count -
119-
tx_queue->read_count >=
120-
tx_queue->efx->txq_entries);
118+
EFX_WARN_ON_ONCE_PARANOID(tx_queue->insert_count -
119+
tx_queue->read_count >=
120+
tx_queue->efx->txq_entries);
121121

122122
buffer->dma_addr = dma_addr;
123123

@@ -134,7 +134,7 @@ static void efx_tx_queue_insert(struct efx_tx_queue *tx_queue,
134134
len -= dma_len;
135135
}
136136

137-
EFX_BUG_ON_PARANOID(!len);
137+
EFX_WARN_ON_ONCE_PARANOID(!len);
138138
buffer->len = len;
139139
*final_buffer = buffer;
140140
}
@@ -147,28 +147,27 @@ static __be16 efx_tso_check_protocol(struct sk_buff *skb)
147147
{
148148
__be16 protocol = skb->protocol;
149149

150-
EFX_BUG_ON_PARANOID(((struct ethhdr *)skb->data)->h_proto !=
151-
protocol);
150+
EFX_WARN_ON_ONCE_PARANOID(((struct ethhdr *)skb->data)->h_proto !=
151+
protocol);
152152
if (protocol == htons(ETH_P_8021Q)) {
153153
struct vlan_ethhdr *veh = (struct vlan_ethhdr *)skb->data;
154154

155155
protocol = veh->h_vlan_encapsulated_proto;
156156
}
157157

158158
if (protocol == htons(ETH_P_IP)) {
159-
EFX_BUG_ON_PARANOID(ip_hdr(skb)->protocol != IPPROTO_TCP);
159+
EFX_WARN_ON_ONCE_PARANOID(ip_hdr(skb)->protocol != IPPROTO_TCP);
160160
} else {
161-
EFX_BUG_ON_PARANOID(protocol != htons(ETH_P_IPV6));
162-
EFX_BUG_ON_PARANOID(ipv6_hdr(skb)->nexthdr != NEXTHDR_TCP);
161+
EFX_WARN_ON_ONCE_PARANOID(protocol != htons(ETH_P_IPV6));
162+
EFX_WARN_ON_ONCE_PARANOID(ipv6_hdr(skb)->nexthdr != NEXTHDR_TCP);
163163
}
164-
EFX_BUG_ON_PARANOID((PTR_DIFF(tcp_hdr(skb), skb->data)
165-
+ (tcp_hdr(skb)->doff << 2u)) >
166-
skb_headlen(skb));
164+
EFX_WARN_ON_ONCE_PARANOID((PTR_DIFF(tcp_hdr(skb), skb->data) +
165+
(tcp_hdr(skb)->doff << 2u)) >
166+
skb_headlen(skb));
167167

168168
return protocol;
169169
}
170170

171-
172171
/* Parse the SKB header and initialise state. */
173172
static int tso_start(struct tso_state *st, struct efx_nic *efx,
174173
struct efx_tx_queue *tx_queue,
@@ -193,9 +192,9 @@ static int tso_start(struct tso_state *st, struct efx_nic *efx,
193192
}
194193
st->seqnum = ntohl(tcp_hdr(skb)->seq);
195194

196-
EFX_BUG_ON_PARANOID(tcp_hdr(skb)->urg);
197-
EFX_BUG_ON_PARANOID(tcp_hdr(skb)->syn);
198-
EFX_BUG_ON_PARANOID(tcp_hdr(skb)->rst);
195+
EFX_WARN_ON_ONCE_PARANOID(tcp_hdr(skb)->urg);
196+
EFX_WARN_ON_ONCE_PARANOID(tcp_hdr(skb)->syn);
197+
EFX_WARN_ON_ONCE_PARANOID(tcp_hdr(skb)->rst);
199198

200199
st->out_len = skb->len - header_len;
201200

@@ -245,8 +244,8 @@ static void tso_fill_packet_with_fragment(struct efx_tx_queue *tx_queue,
245244
if (st->packet_space == 0)
246245
return;
247246

248-
EFX_BUG_ON_PARANOID(st->in_len <= 0);
249-
EFX_BUG_ON_PARANOID(st->packet_space <= 0);
247+
EFX_WARN_ON_ONCE_PARANOID(st->in_len <= 0);
248+
EFX_WARN_ON_ONCE_PARANOID(st->packet_space <= 0);
250249

251250
n = min(st->in_len, st->packet_space);
252251

@@ -379,15 +378,15 @@ int efx_enqueue_skb_tso(struct efx_tx_queue *tx_queue,
379378
/* Find the packet protocol and sanity-check it */
380379
state.protocol = efx_tso_check_protocol(skb);
381380

382-
EFX_BUG_ON_PARANOID(tx_queue->write_count != tx_queue->insert_count);
381+
EFX_WARN_ON_ONCE_PARANOID(tx_queue->write_count != tx_queue->insert_count);
383382

384383
rc = tso_start(&state, efx, tx_queue, skb);
385384
if (rc)
386385
goto fail;
387386

388387
if (likely(state.in_len == 0)) {
389388
/* Grab the first payload fragment. */
390-
EFX_BUG_ON_PARANOID(skb_shinfo(skb)->nr_frags < 1);
389+
EFX_WARN_ON_ONCE_PARANOID(skb_shinfo(skb)->nr_frags < 1);
391390
frag_i = 0;
392391
rc = tso_get_fragment(&state, efx,
393392
skb_shinfo(skb)->frags + frag_i);

0 commit comments

Comments
 (0)