Skip to content

Commit e6854be

Browse files
committed
selftests: drv-net: tso: make bkg() wait for socat to quit
Commit 846742f ("selftests: drv-net: add a warning for bkg + shell + terminate") added a warning for bkg() used with terminate=True. The tso test was missed as we didn't have it running anywhere in NIPA. Add exit_wait=True, to avoid: # Warning: combining shell and terminate is risky! # SIGTERM may not reach the child on zsh/ksh! getting printed twice for every variant. Fixes: 0d0f417 ("selftests: drv-net: add a simple TSO test") Reviewed-by: Willem de Bruijn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c68804c commit e6854be

File tree

1 file changed

+1
-1
lines changed
  • tools/testing/selftests/drivers/net/hw

1 file changed

+1
-1
lines changed

tools/testing/selftests/drivers/net/hw/tso.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def run_one_stream(cfg, ipver, remote_v4, remote_v6, should_lso):
3939
port = rand_port()
4040
listen_cmd = f"socat -{ipver} -t 2 -u TCP-LISTEN:{port},reuseport /dev/null,ignoreeof"
4141

42-
with bkg(listen_cmd, host=cfg.remote) as nc:
42+
with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as nc:
4343
wait_port_listen(port, host=cfg.remote)
4444

4545
if ipver == "4":

0 commit comments

Comments
 (0)